Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor processFilter and processTags #29

Open
LiranCohen opened this issue Apr 23, 2024 · 0 comments
Open

Refactor processFilter and processTags #29

LiranCohen opened this issue Apr 23, 2024 · 0 comments

Comments

@LiranCohen
Copy link
Member

processFilter and processTags have similar functionality and could likely benefit from a slight refactor.

The key difference between the two is that the filters will always match the property's column name, but the tags match against a different column (valueNumber or valueString) depending on the filter value's type.

https://github.com/TBD54566975/dwn-sql-store/blob/main/src/utils/filter.ts#L13-L69

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant