Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change MySQL blob column to longblob #6

Open
amika-sq opened this issue Sep 19, 2023 · 2 comments
Open

Change MySQL blob column to longblob #6

amika-sq opened this issue Sep 19, 2023 · 2 comments

Comments

@amika-sq
Copy link
Collaborator

Currently, each dialect defines the following column types for blobs:

  • MySQL - blob - 64Kb limit
  • Postgres - bytea - 1 GB limit
  • SQLite - blob - 1 GB limit (by default, we can make it go up to 2GB)

MySQL has a LONGBLOB column type, which has a capacity of ~4GB, bringing it more inline with the other dialects.

@amika-sq
Copy link
Collaborator Author

Relevant area of code:
https://github.com/TBD54566975/dwn-sql-store/blob/main/src/dialect/mysql-dialect.ts

I'm currently having environment issues, but it should be something like the following to enable:

return builder.addColumn(columnName, sql`longblob`, callback);

@aniketh-varma
Copy link

Hey @amika-sq, is this issue still relevant?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants