Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include module name in artifact path #3055

Open
2 tasks
jonathanj-square opened this issue Oct 9, 2024 · 2 comments
Open
2 tasks

Include module name in artifact path #3055

jonathanj-square opened this issue Oct 9, 2024 · 2 comments
Assignees

Comments

@jonathanj-square
Copy link
Contributor

Module artifacts stored in the OCI registry using the following path convention: /ftl/modules/<module-digest> but the desired path is /ftl/modules/<module-name>/<module-digest>. When artefact blobs are uploaded to the controller their names are not included (the artefacts table doesn't make use of them).

The change involves:

  • Including the module name when uploading artefact blobs to the controller
  • Modifying the oci registry path naming scheme to account for name.
@jonathanj-square jonathanj-square added the triage Issue needs triaging label Oct 9, 2024
@ftl-robot ftl-robot mentioned this issue Oct 9, 2024
@stuartwdouglas
Copy link
Collaborator

This will not be great for the JVM, as JVM apps share many common Jars. The current addressing scheme allows these jars to be shared between all modules and significantly reduces the amount of data sent over the wire.

@wesbillman
Copy link
Member

@jonathanj-square to capture some thoughts in a 1-pager.

@wesbillman wesbillman added next Work that will be be picked up next and removed triage Issue needs triaging labels Oct 10, 2024
@github-actions github-actions bot removed the next Work that will be be picked up next label Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants