Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider caching DID resolution #105

Open
decentralgabe opened this issue Nov 30, 2023 · 3 comments
Open

Consider caching DID resolution #105

decentralgabe opened this issue Nov 30, 2023 · 3 comments
Assignees

Comments

@decentralgabe
Copy link
Member

const didDocument = await resolveDid(did)

This call can be cached within a reasonable time period (e.g. 10 minutes) to avoid duplicated network calls.

@decentralgabe
Copy link
Member Author

cc: @kirahsapong

@kirahsapong
Copy link
Contributor

i wonder if it is reasonable to save the result, and only in case of failure, fetch and try with new result?

@mistermoe
Copy link
Member

a DidResolverCache cache can be added here. It defaults to no-op if one isn't provided. Given that this is an SDK, we should figure out how to surface the ability to provide one and maybe include 1-2 implementations of DidResolverCache.

@kirahsapong kirahsapong self-assigned this Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

No branches or pull requests

4 participants