Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement validNext check on HTTP Client #205

Open
kirahsapong opened this issue Mar 19, 2024 · 1 comment
Open

Implement validNext check on HTTP Client #205

kirahsapong opened this issue Mar 19, 2024 · 1 comment
Assignees
@kirahsapong
Labels
tbdex-client HTTP client for tbDEX wallets

Comments

@kirahsapong
Copy link
Contributor

Currently the validNext check happens entirely on the server side Exchange State Machine.

If a server implementation doesn't check for validNext messages this could break the exchange flow with no check on the client side. For more robustness we should add a validNext check for messages on the HTTP Client across SDK implementations.

Pushed to post-1.0 since it won't be a breaking change.
@kirahsapong kirahsapong self-assigned this Mar 19, 2024
@kirahsapong
Copy link
Contributor Author

Should discuss as a group and after consensus, need to clone into kt and swift as well

@kirahsapong kirahsapong added the tbdex-client HTTP client for tbDEX wallets label Mar 19, 2024
@kirahsapong kirahsapong mentioned this issue Mar 19, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kirahsapong kirahsapong

Labels
tbdex-client HTTP client for tbDEX wallets
Projects
SDK Development
Status: No status
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kirahsapong