From d8593ada09632280865d2bee813e02a217a2a721 Mon Sep 17 00:00:00 2001
From: Kirah Sapong <kirah@tbd.email>
Date: Thu, 8 Feb 2024 14:17:13 -0800
Subject: [PATCH 1/3] mark pfiDid required property

---
 packages/http-server/src/http-server.ts | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/packages/http-server/src/http-server.ts b/packages/http-server/src/http-server.ts
index 2f3f965b..05f48de0 100644
--- a/packages/http-server/src/http-server.ts
+++ b/packages/http-server/src/http-server.ts
@@ -36,13 +36,12 @@ type CallbackMap = {
 type NewHttpServerOptions = {
   offeringsApi?: OfferingsApi
   exchangesApi?: ExchangesApi,
-  pfiDid?: string
+  pfiDid: string
 }
 
-const defaults: NewHttpServerOptions = {
+const defaults: Omit<NewHttpServerOptions, 'pfiDid'> = {
   offeringsApi : fakeOfferingsApi,
-  exchangesApi : fakeExchangesApi,
-  pfiDid       : 'did:ex:pfi'
+  exchangesApi : fakeExchangesApi
 }
 
 /**

From 0f8657fabf792049faab246cb8980d1fafb6ebcd Mon Sep 17 00:00:00 2001
From: Kirah Sapong <kirah@tbd.email>
Date: Thu, 8 Feb 2024 14:20:29 -0800
Subject: [PATCH 2/3] add changeset

---
 .changeset/gentle-lies-provide.md | 5 +++++
 1 file changed, 5 insertions(+)
 create mode 100644 .changeset/gentle-lies-provide.md

diff --git a/.changeset/gentle-lies-provide.md b/.changeset/gentle-lies-provide.md
new file mode 100644
index 00000000..eec35f38
--- /dev/null
+++ b/.changeset/gentle-lies-provide.md
@@ -0,0 +1,5 @@
+---
+"@tbdex/http-server": minor
+---
+
+Requires consumer to pass pfiDid when instantiating a new TbdexHttpServer

From 1d13ed22844927727733b918f9f549ca077d1e27 Mon Sep 17 00:00:00 2001
From: Kirah Sapong <kirah@tbd.email>
Date: Thu, 8 Feb 2024 14:50:09 -0800
Subject: [PATCH 3/3] remove defaults obj

---
 packages/http-server/src/http-server.ts | 13 +++----------
 1 file changed, 3 insertions(+), 10 deletions(-)

diff --git a/packages/http-server/src/http-server.ts b/packages/http-server/src/http-server.ts
index 05f48de0..eca593aa 100644
--- a/packages/http-server/src/http-server.ts
+++ b/packages/http-server/src/http-server.ts
@@ -39,11 +39,6 @@ type NewHttpServerOptions = {
   pfiDid: string
 }
 
-const defaults: Omit<NewHttpServerOptions, 'pfiDid'> = {
-  offeringsApi : fakeOfferingsApi,
-  exchangesApi : fakeExchangesApi
-}
-
 /**
  * TBDex HTTP Server powered by Express
  * @beta
@@ -76,12 +71,10 @@ export class TbdexHttpServer {
 
   constructor(opts?: NewHttpServerOptions) {
     this.callbacks = {}
-    opts = { ...defaults, ...opts }
-    const { offeringsApi, exchangesApi, pfiDid } = opts
 
-    this.exchangesApi = exchangesApi
-    this.offeringsApi = offeringsApi
-    this.pfiDid = pfiDid
+    this.exchangesApi = opts?.exchangesApi ?? fakeExchangesApi
+    this.offeringsApi = opts?.offeringsApi ?? fakeOfferingsApi
+    this.pfiDid = opts?.pfiDid ?? 'did:ex:pfi'
 
     // initialize api here so that consumers can attach custom endpoints
     const api = express()