Remove exchangeId from submit endpoint paths #182
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diehuxx
requested review from
michaelneale,
mistermoe,
jiyoontbd,
phoebe-lew,
KendallWeihe and
kirahsapong
as code owners
|
|
TBDocs Report 🛑 Errors: 0 @tbdex/protocol
@tbdex/http-client
@tbdex/http-server
TBDocs Report Updated at 2024-02-21T23:57:04Z |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #182 +/- ##
=======================================
Coverage 92.52% 92.52%
=======================================
Files 37 37
Lines 3011 3011
Branches 326 326
=======================================
Hits 2786 2786
Misses 225 225
|
phoebe-lew
reviewed
Mar 6, 2024
| @@ -77,7 +77,7 @@ describe('client', () => { | |||
| expect(e.statusCode).to.exist | |||
| expect(e.details).to.exist | |||
| expect(e.recipientDid).to.equal(pfiDid.uri) | |||
| expect(e.url).to.equal(`https://localhost:9000/exchanges/${rfq.metadata.exchangeId}/rfq`) | |||
| expect(e.url).to.equal(`https://localhost:9000/exchanges/rfq`) | |||
There was a problem hiding this comment.
I think for creating an exchange, this should be https://localhost:9000/exchanges?
There was a problem hiding this comment.
Suggested change
| expect(e.url).to.equal(`https://localhost:9000/exchanges/rfq`) | |
| expect(e.url).to.equal(`https://localhost:9000/exchanges`) |
| @@ -140,22 +140,22 @@ export class TbdexHttpServer { | |||
| listen(port: number | string, callback?: () => void) { | |||
| const { offeringsApi, exchangesApi, pfiDid } = this | |||
|
|
|||
| this.api.post('/exchanges/:exchangeId/rfq', (req: Request, res: Response) => | |||
| this.api.post('/exchanges/rfq', (req: Request, res: Response) => | |||
There was a problem hiding this comment.
Suggested change
| this.api.post('/exchanges/rfq', (req: Request, res: Response) => | |
| this.api.post('/exchanges', (req: Request, res: Response) => |
| @@ -23,7 +23,7 @@ describe('POST /exchanges/:exchangeId/rfq', () => { | |||
| }) | |||
|
|
|||
| it('returns a 400 if no request body is provided', async () => { | |||
| const resp = await fetch('http://localhost:8000/exchanges/123/rfq', { | |||
| const resp = await fetch('http://localhost:8000/exchanges/rfq', { | |||
There was a problem hiding this comment.
Suggested change
| const resp = await fetch('http://localhost:8000/exchanges/rfq', { | |
| const resp = await fetch('http://localhost:8000/exchanges', { |
| @@ -38,7 +38,7 @@ describe('POST /exchanges/:exchangeId/rfq', () => { | |||
| }) | |||
|
|
|||
| it('returns a 400 if request body is not a valid json object', async () => { | |||
| const resp = await fetch('http://localhost:8000/exchanges/123/rfq', { | |||
| const resp = await fetch('http://localhost:8000/exchanges/rfq', { | |||
There was a problem hiding this comment.
Suggested change
| const resp = await fetch('http://localhost:8000/exchanges/rfq', { | |
| const resp = await fetch('http://localhost:8000/exchanges', { |
| @@ -59,7 +59,7 @@ describe('POST /exchanges/:exchangeId/rfq', () => { | |||
| const rfq = await DevTools.createRfq({ sender: aliceDid, receiver: pfiDid }) | |||
| await rfq.sign(aliceDid) | |||
|
|
|||
| const resp = await fetch('http://localhost:8000/exchanges/123/rfq', { | |||
| const resp = await fetch('http://localhost:8000/exchanges/rfq', { | |||
There was a problem hiding this comment.
Suggested change
| const resp = await fetch('http://localhost:8000/exchanges/rfq', { | |
| const resp = await fetch('http://localhost:8000/exchanges', { |
| @@ -198,7 +198,7 @@ describe('POST /exchanges/:exchangeId/rfq', () => { | |||
| }) | |||
| await rfq.sign(aliceDid) | |||
|
|
|||
| const resp = await fetch('http://localhost:8000/exchanges/123/rfq', { | |||
| const resp = await fetch('http://localhost:8000/exchanges/rfq', { | |||
There was a problem hiding this comment.
Suggested change
| const resp = await fetch('http://localhost:8000/exchanges/rfq', { | |
| const resp = await fetch('http://localhost:8000/exchanges', { |
| @@ -303,7 +303,7 @@ describe('POST /exchanges/:exchangeId/rfq', () => { | |||
| }) | |||
|
|
|||
| it('returns a 202 if RFQ is accepted', async () => { | |||
| const resp = await fetch('http://localhost:8000/exchanges/123/rfq', { | |||
| const resp = await fetch('http://localhost:8000/exchanges/rfq', { | |||
There was a problem hiding this comment.
Suggested change
| const resp = await fetch('http://localhost:8000/exchanges/rfq', { | |
| const resp = await fetch('http://localhost:8000/exchanges', { |
| @@ -318,7 +318,7 @@ describe('POST /exchanges/:exchangeId/rfq', () => { | |||
| }) | |||
| api.onSubmitRfq(callbackSpy) | |||
|
|
|||
| const resp = await fetch('http://localhost:8000/exchanges/123/rfq', { | |||
| const resp = await fetch('http://localhost:8000/exchanges/rfq', { | |||
There was a problem hiding this comment.
Suggested change
| const resp = await fetch('http://localhost:8000/exchanges/rfq', { | |
| const resp = await fetch('http://localhost:8000/exchanges', { |
| @@ -343,7 +343,7 @@ describe('POST /exchanges/:exchangeId/rfq', () => { | |||
|
|
|||
| const replyTo = 'https://tbdex.io/example' | |||
|
|
|||
| const resp = await fetch('http://localhost:8000/exchanges/123/rfq', { | |||
| const resp = await fetch('http://localhost:8000/exchanges/rfq', { | |||
There was a problem hiding this comment.
Suggested change
| const resp = await fetch('http://localhost:8000/exchanges/rfq', { | |
| const resp = await fetch('http://localhost:8000/exchanges', { |
| const pfiServiceEndpoint = await TbdexHttpClient.getPfiServiceEndpoint(pfiDid) | ||
| const apiRoute = `${pfiServiceEndpoint}/exchanges/${exchangeId}/${kind}` | ||
| const apiRoute = `${pfiServiceEndpoint}/exchanges/${kind}` |
There was a problem hiding this comment.
only add ${kind} if not RFQ
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements spec change TBD54566975/tbdex#243 TBD54566975/tbdex#225