Skip to content
This repository was archived by the owner on Dec 12, 2024. It is now read-only.
This repository was archived by the owner on Dec 12, 2024. It is now read-only.

Make paymentDetails field within PrivatePaymentDetail object required instead of optional #308

@kirahsapong

Description

@kirahsapong

paymentDetails is marked as optional within the PrivatePaymentDetail object, which is also optional in privateData.

Proposal: paymentDetails should be required. ie. If passing the optional PrivatePaymentDetail, it must contain paymentDetails.

https://github.com/TBD54566975/tbdex/tree/main/specs/protocol#privatepaymentdetails

| field            | data type | required | description                                                                                                                                                                                                                                |
| ---------------- | --------- | -------- | ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------ |
| `paymentDetails` | object    | N        | An object containing the properties defined in an Offering's `requiredPaymentDetails` json schema. If `data.payin/payout.paymentDetailsHash` is omitted, then `privateData.payin/payout.paymentDetails` respectively must also be omitted. |

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    Status

    No status

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions