Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub CI workflow should fail if cargo fmt edits source code #200

Closed
KendallWeihe opened this issue May 11, 2024 · 0 comments · Fixed by #203
Closed

GitHub CI workflow should fail if cargo fmt edits source code #200

KendallWeihe opened this issue May 11, 2024 · 0 comments · Fixed by #203

Comments

@KendallWeihe
Copy link
Contributor

Prior to #187, if the call to cargo fmt actually changed the underlying source code then the pipeline would fail, which would indicate to the developer they need to format their code and then push changes. But since we moved to #187 that feature is no longer enforced, I noticed because in #199 I had formatting changes which were from where #193 didn't run just lint prior to merging, but it wasn't caught because the pipeline didn't fail. The pipeline shouldn't allow this to happen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant