Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump dwn-sdk-js to v0.2.2 and remove patch #106

Closed
shamilovtim opened this issue Sep 20, 2023 · 6 comments · Fixed by #138
Closed

Bump dwn-sdk-js to v0.2.2 and remove patch #106

shamilovtim opened this issue Sep 20, 2023 · 6 comments · Fixed by #138
Assignees

Comments

@shamilovtim
Copy link
Member

  • Latest dwn-sdk-js is out
  • Patch can be removed
@amika-sq amika-sq self-assigned this Sep 22, 2023
@amika-sq
Copy link
Contributor

amika-sq commented Sep 22, 2023

I have the bump in mobile repo on a branch: amika/bump-dwn

However, the @web5/agent package hasn't been updated yet, which is causing our instantiation of DwnManager to not work appropriately: https://github.com/TBD54566975/web5-wallet/blob/amika/bump-dwn/src/features/identity/IdentityAgentManager.ts#L31

Once the Web5 packages are updated, we should be able to upgrade. I'll work with them to get a PR up!

@amika-sq
Copy link
Contributor

amika-sq commented Sep 22, 2023

Found an oddity in the constructors for the various data stores in the DWN. Made a PR against it here: TBD54566975/dwn-sdk-js#513

@diehuxx
Copy link

diehuxx commented Sep 22, 2023

However, the @web5/agent package hasn't been updated yet

Hi @amika-sq -- I'm working on this today and Monday. Tonight I'll push a branch with my progress, though it may still be WIP at that point.

@amika-sq
Copy link
Contributor

amika-sq commented Oct 3, 2023

Looks like we're getting close! Will be able to PR this once this is in:
TBD54566975/web5-js#225

@diehuxx
Copy link

diehuxx commented Oct 3, 2023

@amika-sq she's merged :)

@amika-sq
Copy link
Contributor

amika-sq commented Oct 3, 2023

Perfect! I'll go ahead and make an alpha version of the web5 packages and get it integrated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants