Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace naive.stamp with naive.stump, with new parameter row_traversal #598

Closed
NimaSarajpoor opened this issue May 5, 2022 · 1 comment
Closed

Replace naive.stamp with naive.stump, with new parameter row_traversal #598

NimaSarajpoor opened this issue May 5, 2022 · 1 comment

Comments

@NimaSarajpoor
Copy link
Collaborator

As discussed in PR #595, we would like to replace naive.stamp with naive.stump(...., row_traversal=True). It seems that the function naive.stamp is used in several unit test files. To avoid pushing all these files, I created this issue so that we can address it first before moving forward in the PR, and make sure it passes all unit tests.
@NimaSarajpoor NimaSarajpoor changed the title Replacing naive.stamp with naive.stump, with new parameter row_traversal Replace naive.stamp with naive.stump, with new parameter row_traversal May 5, 2022
@seanlaw
Copy link
Contributor

seanlaw commented May 6, 2022

Sounds good

@NimaSarajpoor NimaSarajpoor mentioned this issue May 6, 2022
Merged
@seanlaw seanlaw closed this as completed in 252d732 May 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@seanlaw @NimaSarajpoor