From ed18b7b488555a4a72126ff8536447ac62ad1c75 Mon Sep 17 00:00:00 2001 From: Guewen Baconnier Date: Wed, 2 Dec 2020 08:05:24 +0100 Subject: [PATCH] s_available_to_promise_release: fix picking w/out move lines When computing date_priority, if a picking has no move lines or some move lines have no date_priority, we can have errors because min() is called without sequence or compares bool and datetime. --- stock_available_to_promise_release/models/stock_picking.py | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/stock_available_to_promise_release/models/stock_picking.py b/stock_available_to_promise_release/models/stock_picking.py index 0d9f137481..a8e49280f0 100644 --- a/stock_available_to_promise_release/models/stock_picking.py +++ b/stock_available_to_promise_release/models/stock_picking.py @@ -108,7 +108,12 @@ def _search_release_ready(self, operator, value): @api.depends("move_lines.date_priority") def _compute_date_priority(self): for picking in self: - picking.date_priority = min(picking.move_lines.mapped("date_priority")) + dates = [ + date_priority + for date_priority in picking.move_lines.mapped("date_priority") + if date_priority + ] + picking.date_priority = min(dates) if dates else False def release_available_to_promise(self): # When the stock.picking form view is opened through the "Deliveries"