eslint no-restricted-syntax: remove for..in

Author: gpittarelli

Diff for: .eslintrc.json

@@ -65,6 +65,13 @@
     "semi": [
       2,
       "always"
+    ],
+    "no-restricted-syntax": [
+      2,
+      "DebuggerStatement",
+      "ForInStatement",
+      "LabeledStatement",
+      "WithStatement"
     ]
   },
   "plugins": [

Diff for: src/app/app.filter.js

@@ -112,19 +112,14 @@ function secondsToMinutes_AngularWrapper() {
 /** @ngInject */
 function unique() {
   return function (array, uniqueKey) {
-    var uniqueArray = [];
-    for (var key in array) {
-      var existsInArray = false;
-      for (var j in uniqueArray) {
-        if (uniqueArray[j][uniqueKey] === array[key][uniqueKey]) {
-          existsInArray = true;
-        }
+    return array.reduce(([out, seen], o) => {
+      let { [uniqueKey]: v } = o;
+      if (!seen.has(v)) {
+        seen.add(v);
+        out.push(o);
       }
-      if (!existsInArray) {
-        uniqueArray.push(array[key]);
-      }
-    }
-    return uniqueArray;
+      return [out, seen];
+    }, [[], new Set()])[0];
   };
 }
 

Diff for: src/app/app.notifications.js

@@ -192,9 +192,9 @@ export function NotificationsFactory($rootScope, $mdToast, $window, $document,
                  options.timeout * 1000);
       }
 
-      for (var callback in options.callbacks) {
+      Object.keys(options.callbacks).forEach((callback) => {
         html5notification[callback] = options.callbacks[callback];
-      }
+      });
     });
   };
 

Diff for: src/app/app.settings.js

@@ -103,16 +103,14 @@ function SettingsConfigBlock(SettingsProvider, VocalNotifications) {
      Defaults every value found in the filters to true.
      It gets overwritten with the loaded settings in the SettingsRunBlock
      */
-    for (var settingsGroupKey in SettingsProvider.constants.filters) {
-      var settingsGroup = SettingsProvider.constants.filters[settingsGroupKey];
-      for (var setting in settingsGroup) {
+    Object.keys(SettingsProvider.constants.filters).forEach(settingsGroupKey => {
+      Object.keys(SettingsProvider.constants.filters[settingsGroupKey]).forEach(setting => {
         SettingsProvider.settings[setting] = true;
-      }
-    }
+      });
+    });
 
     // show all lobbies (even non-Mumble-required) by default
     SettingsProvider.settings.mumbleRequired = false;
-
   }
 
   setDefaultValues();
@@ -136,14 +134,14 @@ function Settings() {
     var settings = settingsProvider.settings;
     var alreadyLoadedFromBackend = false;
 
-    for (var settingKey in localStorage) {
+    for (var settingKey of Object.keys(localStorage)) {
       settings[settingKey] = localStorage.getItem(settingKey);
     }
 
     $rootScope.$emit('settings-updated');
 
     Websocket.onJSON('playerSettings', function (data) {
-      for (var setting in data) {
+      for (var setting of Object.keys(data)) {
         var value = data[setting];
         // coerce true/false for conveniece
         if (value === 'true' || value === 'false') {

Diff for: src/app/pages/lobby/create/lobby-create.controller.js

@@ -12,7 +12,7 @@ function LobbyCreateController($document, $state, $scope, $rootScope,
   var vm = this;
 
   var lobbySettingsList = LobbyCreate.getSettingsList();
-  for (var key in lobbySettingsList) {
+  for (var key of Object.keys(lobbySettingsList)) {
     vm[key] = lobbySettingsList[key];
   }
 

Diff for: src/app/pages/settings/settings.controller.js

@@ -75,9 +75,9 @@ function SettingsPageController($rootScope, $scope, $mdEditDialog,
    If it doesn't, it defaults to true.
    */
   var populateFilters = function (userSettings) {
-    for (var settingsGroupKey in vm.sections.filters) {
+    for (var settingsGroupKey of Object.keys(vm.sections.filters)) {
       var settingsGroup = vm.sections.filters[settingsGroupKey];
-      for (var fieldKey in settingsGroup) {
+      for (var fieldKey of Object.keys(settingsGroup)) {
         settingsGroup[fieldKey].selected = userSettings[fieldKey];
       }
     }

Diff for: src/app/pages/settings/settings.provider.js

@@ -27,7 +27,7 @@ function SettingsPageConfig($stateProvider, SettingsPageProvider) {
     'account',
   ];
 
-  for (var settingSectionKey in SettingsPageProvider.sections) {
+  for (var settingSectionKey of Object.keys(SettingsPageProvider.sections)) {
     var settingSection = SettingsPageProvider.sections[settingSectionKey];
     $stateProvider.state(settingSection, {
       url: '/' + settingSection,