gulp: run lint over test scripts

Author: gpittarelli

.eslintignore

@@ -0,0 +1,2 @@
+dist/
+gulp/

gulp/lint.js

@@ -13,7 +13,8 @@ function isFixed(file) {
 
 function runLinter(tryToFix) {
   var codePath = path.join(conf.paths.src, 'app');
-  return gulp.src(path.join(codePath, '**/*.js'))
+  return gulp.src([path.join(codePath, '**/*.js'),
+                   path.join(conf.paths.test, '**/*.js')])
     .pipe($.eslint({ fix: tryToFix }))
     .pipe($.eslint.format())
     .pipe($.if(isFixed, gulp.dest(codePath)))

gulp/test.js

@@ -28,7 +28,7 @@ gulp.task('test:unit', function (done) {
             // upgrade to phantomjs2 is complete
             'node_modules/es5-shim/es5-shim.js',
             src_files,
-            'test/karma/**/*.js'),
+            path.join(conf.paths.test, '/karma/**/*.js')),
         singleRun: true
       });
 

test/karma/chat.service.js

@@ -1,4 +1,8 @@
+/*global describe,beforeEach,it,sinon,expect,module,inject */
+
 describe('Service: ChatService', function () {
+  'use strict';
+
   function makeTestMessage() {
     // The chat service may mutate the received object, so use a
     // factory like this to make the tests are truly isolated
@@ -25,8 +29,8 @@ describe('Service: ChatService', function () {
 
   beforeEach(function () {
     mockWebsocket = sinon.stub({
-      onJSON: function (name, callback) {},
-      emitJSON: function (name, data, callback) {}
+      onJSON: function () {},
+      emitJSON: function () {}
     });
 
     mockLobbyService = sinon.stub({