Fix protobuf parser regex to handle scientific notation #87
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem:
The regex pattern on line 241 could not parse floating-point values
with scientific notation (e.g., 1.42109e-16), causing failures when
loading 15 out of 17 IBM (ICCAD04) benchmarks.
Root Cause:
The pattern `\-*\w+\.\*\/{0,1}\w*[\w+\/{0,1}\w*]*` splits on word
boundaries, breaking scientific notation into separate tokens:
- Input: "f: 1.42109e-16"
- Parsed as: ['f', '1.42109e', '-16']
- Caused float('1.42109e') to fail with ValueError
Solution:
Updated regex to explicitly match scientific notation first, then
fallback to other patterns:
- Pattern: r'[-+]?\d+\.?\d*[eE][-+]?\d+|[-]?\w+\.?[\w/]*'
- Now parses: ['f', '1.42109e-16']
- Correctly handles positive/negative exponents
Testing:
Verified all 17 IBM benchmarks now parse successfully:
- ibm01-ibm18 (excluding ibm05) all load without errors
- Regex still correctly handles:
* Regular floats (0.4, -0.4)
* Integers (123)
* Strings (TOP, BOTTOM)
* Paths (foo/bar)
* Scientific notation (1.42109e-16, 5.68434e+10)
Impact:
This fix enables plc_client_os to parse the full ICCAD04 benchmark
suite without requiring Circuit Training's proprietary parser.
Signed-off-by: willpartcl <[email protected]>
willpartcl
force-pushed
the
fix-scientific-notation-parsing
branch
from
f5bb952 to
45a721d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
The regex pattern on line 241 could not parse floating-point values with scientific notation (e.g., 1.42109e-16), causing failures when loading 15 out of 17 IBM (ICCAD04) benchmarks.
Root Cause:
The pattern
\-*\w+\.\*\/{0,1}\w*[\w+\/{0,1}\w*]*splits on word boundaries, breaking scientific notation into separate tokens:Solution:
Updated regex to explicitly match scientific notation first, then fallback to other patterns:
Testing:
Verified all 17 IBM benchmarks now parse successfully:
Impact:
This fix enables plc_client_os to parse the full ICCAD04 benchmark suite without requiring Circuit Training's proprietary parser.