Skip to content

Commit 1fe01d4

Browse files
Fix Bug: imagePullSecrets not working for autograding (#270)
1 parent 0157b8a commit 1fe01d4

File tree

2 files changed

+4
-3
lines changed

2 files changed

+4
-3
lines changed

charts/grader-service/values.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@ kubeAutogradeExecutor:
6060
image: ghcr.io/tu-wien-datalab/grader-service-labextension
6161
tag: latest
6262
imagePullPolicy: "Always"
63-
imagePullSecrets: {}
63+
imagePullSecrets: []
6464
labels: {}
6565
namespace: null
6666
extraVolumes: ""

grader_service/autograding/kube/kube_grader.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -153,10 +153,10 @@ class KubeAutogradeExecutor(LocalAutogradeExecutor):
153153
help="The image pull policy for the pod. Defaults to 'Always'.").tag(config=True)
154154

155155
# Dictionary to store image pull secrets, helpful when pulling from private registries
156-
image_pull_secrets = Dict(default_value=None,
156+
image_pull_secrets = List(default_value=[],
157157
help="""Autograding pod image pull secrets dictionary (str, str).
158158
Used for pulling images from private registries. Defaults to None.""",
159-
key_trait=Unicode(),
159+
key_trait=Unicode(),
160160
value_trait=Unicode(),
161161
allow_none=True).tag(config=True)
162162

@@ -319,6 +319,7 @@ def start_pod(self) -> GraderPod:
319319
env=env,
320320
image=self.get_image(),
321321
image_pull_policy=self.image_pull_policy,
322+
image_pull_secrets=self.image_pull_secrets,
322323
working_dir="/",
323324
volumes=volumes,
324325
volume_mounts=volume_mounts,

0 commit comments

Comments
 (0)