Release 0.8.2 (#298)

* Fix: feedback generation failing with student notebooks (#288)

* fix: Improve logging when feedback generation fails

* chore: Remove an unused dataclass, fix some typos and type annotations

* fix: Fix a potential security issue when running Git commands in a subprocess

When running multiple commands with `sh -c ...`, it would be easier to construct
the variable "message" so that it contained some executable code.

* fix: Fix a typo in the log message after a successful autograde job

* fix: Do not try to generate feedback for notebooks created by students

If the instructor specifies '*.ipynb' in the whitelist of an assignment,
additional notebooks created by students are also copied over. The feedback
generator should not try to generate feedback for them - they are not in
the gradebook and an attempt to do so would fail.

Refs: #272

* fix: Improve error handling and logging in GitBaseHandler.git_reponse()

* refactor: changed load_roles dict entries to lists (#292)

* refactor: changed load_roles dict entries to lists

* chore: added new load_roles style to dev env

* Update a docstring

---------

Co-authored-by: Natalia Maniakowska <[email protected]>

* fix: Set missing display_name for a new user in auth_to_user (#291)

* fix: renamed sync_on_feedback var (#294)

* Fix: (soft-)delete submission endpoint (#295)

* refactor: Small improvements related to submission handling

* fix: Fix soft-deleting a submission

Now:
- double delete does NOT remove the submission from the db; it just has the state `deleted`;
- if the deadline is not set, it is possible to delete a submission;
- a student can only delete own submission.

* fix: Make `SubmissionObjectHandler.delete()` async

* chore: Write tests for the delete submission endpoint

* fix: Fix some invalid feedback status values in submission handlers tests

* chore: Update the docstring for submission's delete

* Bump service to 0.8.2

* Bump chart to 0.8.2

* docs: fixed helm repo url

---------

Co-authored-by: Natalia Maniakowska <[email protected]>

Author: florian-jaeger

charts/grader-service-all-in-one/Chart.yaml

@@ -15,18 +15,18 @@ type: application
 # This is the chart version. This version number should be incremented each time you make changes
 # to the chart and its templates, including the app version.
 # Versions are expected to follow Semantic Versioning (https://semver.org/)
-version: 0.8.1
+version: 0.8.2
 
 # This is the version number of the application being deployed. This version number should be
 # incremented each time you make changes to the application. Versions are not expected to
 # follow Semantic Versioning. They should reflect the version the application is using.
 # It is recommended to use it with quotes.
-appVersion: "0.8.1"
+appVersion: "0.8.2"
 
 dependencies:
 - name: jupyterhub
   version: 4.2.0
   repository: https://jupyterhub.github.io/helm-chart
 - name: grader-service
-  version: 0.8.1
+  version: 0.8.2
   repository: https://tu-wien-datalab.github.io/grader-service/

charts/grader-service/Chart.yaml

@@ -15,10 +15,10 @@ type: application
 # This is the chart version. This version number should be incremented each time you make changes
 # to the chart and its templates, including the app version.
 # Versions are expected to follow Semantic Versioning (https://semver.org/)
-version: 0.8.1
+version: 0.8.2
 
 # This is the version number of the application being deployed. This version number should be
 # incremented each time you make changes to the application. Versions are not expected to
 # follow Semantic Versioning. They should reflect the version the application is using.
 # It is recommended to use it with quotes.
-appVersion: "0.8.1"
+appVersion: "0.8.2"

charts/grader-service/pyproject.toml

@@ -3,7 +3,7 @@
 github_url = "https://github.com/TU-Wien-dataLAB/grader-service"
 
 [tool.tbump.version]
-current = "0.8.1"
+current = "0.8.2"
 
 # Example of a semver regexp.
 # Make sure this matches current_version before

docs/source/_static/openapi/grader_api.yml

@@ -4,7 +4,7 @@ info:
   description: The REST API for the grader service
   license:
     name: BSD-3-Clause
-  version: '0.8.1'
+  version: '0.8.2'
 servers:
   - url: /api
     description: relative path to mock

docs/source/configuration/auth.md

@@ -165,10 +165,9 @@ c.GraderService.authenticator_class = DummyAuthenticator
 c.Authenticator.allowed_users = {'admin', 'instructor', 'student', 'tutor'}
 c.Authenticator.admin_users = {'admin'}
 # default roles
-c.GraderService.load_roles = {"lect1": {"members": ["admin", "instructor"], "role": "instructor"},
-                              "lect1": {"members": ["tutor"], "role": "tutor"},
-                              "lect1": {"members": ["student"], "role": "student"},
-                             }
+c.GraderService.load_roles = {"lect1": [{"members": ["admin", "instructor"], "role": "instructor"},
+                                        {"members": ["tutor"], "role": "tutor"},
+                                        {"members": ["student"], "role": "student"}]}
 
 # JupyterHub client config
 c.GraderService.oauth_clients = [{

docs/source/installation/kubernetes.md

@@ -8,7 +8,7 @@
     - [Install Helm](https://helm.sh/docs/intro/install/)
     - [Add the Helm repository](https://helm.sh/docs/intro/quickstart/#add-a-helm-repository)
     ```bash
-    helm repo add grader-service ghcr.io/tu-wien-datalab/grader-service
+    helm repo add grader-service https://tu-wien-datalab.github.io/grader-service/
     ```
 - [RabbitMQ operator](https://www.rabbitmq.com/kubernetes/operator/install-operator#installation) installed
 

examples/dev_environment/grader_service_config.py

@@ -50,7 +50,9 @@
 c.Authenticator.allowed_users = {"admin", "instructor", "student", "tutor"}
 c.Authenticator.admin_users = {"admin"}
 c.GraderService.load_roles = {
-    "lect1": {"members": ["admin", "instructor"], "role": "instructor"},
-    "lect1": {"members": ["tutor"], "role": "tutor"},
-    "lect1": {"members": ["student"], "role": "student"},
+    "lecture1": [
+        {"members": ["student"], "role": "student"},
+        {"members": ["tutor"], "role": "tutor"},
+        {"members": ["instructor", "admin"], "role": "instructor"},
+    ]
 }

examples/dev_environment/grader_service_config_test.py

@@ -111,7 +111,9 @@ def post_auth_hook(authenticator: Authenticator, handler: BaseHandler, authentic
 c.Authenticator.admin_users = {"admin"}
 
 c.GraderService.load_roles = {
-    "lect1:instructor": ["admin", "instructor"],
-    "lect1:student": ["student"],
-    "lect1:tutor": ["tutor"],
+    "lecture1": [
+        {"members": ["student"], "role": "student"},
+        {"members": ["tutor"], "role": "tutor"},
+        {"members": ["instructor", "admin"], "role": "instructor"},
+    ]
 }

grader_service/_version.py

@@ -5,4 +5,4 @@
 # LICENSE file in the root directory of this source tree.
 
 # version_info updated by running `tbump`
-__version__ = "0.8.1"
+__version__ = "0.8.2"

grader_service/autograding/celery/tasks.py

@@ -79,7 +79,10 @@ def generate_feedback_task(self: GraderTask, lecture_id: int, assignment_id: int
 
     executor = GenerateFeedbackExecutor(grader_service_dir, submission, config=self.celery.config)
     executor.start()
-    self.log.info(f"Successfully generated feedback for submission {submission.id}!")
+    if submission.feedback_status == "generated":
+        self.log.info("Successfully generated feedback for submission %s!", submission.id)
+    else:
+        self.log.error("Failed to generate feedback for submission %s!", submission.id)
 
 
 @app.task(bind=True, base=GraderTask)
@@ -94,7 +97,7 @@ async def lti_sync_task(
     :param lecture: lecture object
     :param assignment: assignment object
     :param submissions: submissions to be synced
-    :param feedback_sync(optional): if True, the given submission is part of a fully automated grading assignment
+    :param feedback_sync(optional): if True, the sync task was started by a feedback generation
     """
     lti_plugin = LTISyncGrades.instance()
     # check if the lti plugin is enabled