Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding new admins via names impossible #1394

Open
CommanderStorm opened this issue Oct 26, 2024 · 4 comments
Open

Adding new admins via names impossible #1394

CommanderStorm opened this issue Oct 26, 2024 · 4 comments

Comments

@CommanderStorm
Copy link
Member

CommanderStorm commented Oct 26, 2024

Describe the bug

Currently, adding NEW (not already existing accounts) does not seem to work

To Reproduce
Steps to reproduce the behavior:

  1. Go to the admin pannel
  2. add the name you want to add, see the search bar populate with some names
  3. Don't find https://campus.tum.de/tumonline/visitenkarte.show_vcard?pPersonenId=FAFA936E6EE50C59&pPersonenGruppe=3

Expected behavior
I expect to be able to find all employees, possibly even all students via the search bar to add moderators.

Screenshots

Desktop (please complete the following information):

  • OS: Linux
  • Browser Chrome
  • Version 129.0.6668.100

Additional context

The placeholder is a TUM-Kennung, but since searching by names also works, I'd expect this to be an LDAP lookup.

@joschahenningsen
Copy link
Member

That person will only show up if they ever logged into tum live before. Did you verify this?

@CommanderStorm
Copy link
Member Author

Alex did log in to watch videos before.
Not as an admin, but there should not be a restriction on that for adding moderators.

Anyhow:
If logging in is a requirement, we should change the helptext.

@karjo24
Copy link
Contributor

karjo24 commented Oct 31, 2024

I expect to be able to find all employees, possibly even all students via the search bar to add moderators.

As far as I can see, you can find every user including students in our database (with the restriction of the user having logged in at least once before as Joscha mentioned)

Alex did log in to watch videos before.

Can you find him using his LRZ-ID? Not every user (the majority of users) in the database has a last name attached to it, so maybe Alexander Pach is one of them which would explain you not finding them. However, I don't know when a last name is added for users and when there's not. (=> change this behaviour if the last name is not added by default?)

@CommanderStorm
Copy link
Member Author

Not every user (the majority of users) in the database has a last name attached to it

That solves my confusion.
Yes, via the TUM-Kennnung I can find him.

This being consitent and working even if I use his name over all users would be nice though.
Alternatively, using the name should act as a search if it is just first names..

@CommanderStorm CommanderStorm changed the title Adding new admins impossible Adding new admins via names impossible Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants