{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":820743136,"defaultBranch":"master","name":"godot","ownerLogin":"TV4Fun","currentUserCanPush":false,"isFork":true,"isEmpty":false,"createdAt":"2024-06-27T05:12:06.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/4702728?v=4","public":true,"private":false,"isOrgOwned":false},"refInfo":{"name":"","listCacheKey":"v0:1719988984.0","currentOid":""},"activityList":{"items":[{"before":"4964983dee89fe928a21d2044cacd478a74230a8","after":"785359c98d6e20b8c5e638e5df79aa678c0f7c18","ref":"refs/heads/devel","pushedAt":"2024-07-04T02:48:40.000Z","pushType":"push","commitsCount":156,"pusher":{"login":"TV4Fun","name":"Joel Croteau","path":"/TV4Fun","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/4702728?s=80&v=4"},"commit":{"message":"Merge branch 'master' into devel","shortMessageHtmlLink":"Merge branch 'master' into devel"}},{"before":"029246d8b6645a5f705f2ccd6beb5518f39aae21","after":"0d5a775cff37e16888f9564e585aecafe19c2ca8","ref":"refs/heads/master","pushedAt":"2024-07-04T02:29:16.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"TV4Fun","name":"Joel Croteau","path":"/TV4Fun","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/4702728?s=80&v=4"},"commit":{"message":"Prefix arguments with `p_`\n\nIncorporate suggestions from @AThousandShips and necessary code changes to make\nthose work.","shortMessageHtmlLink":"Prefix arguments with <code>p_</code>"}},{"before":"a50b7502bfb13712cd6861d1be48f0c0ac93c0c7","after":"4964983dee89fe928a21d2044cacd478a74230a8","ref":"refs/heads/devel","pushedAt":"2024-07-03T19:27:37.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"TV4Fun","name":"Joel Croteau","path":"/TV4Fun","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/4702728?s=80&v=4"},"commit":{"message":"Remove binding for `VariantUtilityFunctions::join()`","shortMessageHtmlLink":"Remove binding for <code>VariantUtilityFunctions::join()</code>"}},{"before":"5fcc1ce8dc662f0191955cf605bebd25be310d1d","after":"029246d8b6645a5f705f2ccd6beb5518f39aae21","ref":"refs/heads/master","pushedAt":"2024-07-03T06:47:16.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"TV4Fun","name":"Joel Croteau","path":"/TV4Fun","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/4702728?s=80&v=4"},"commit":{"message":"Remove unnecessary `i == 0` checks from string building loops\n\n`String` is auto-initialized to be empty and `String::operator+=`\n[already checks](https://github.com/godotengine/godot/blob/f0d15bbfdfde1c1076903afb7a7db373580d5534/core/string/ustring.cpp#L520)\nif it is empty before appending, so this check is pointless and just needlessly\nclutters the codebase.","shortMessageHtmlLink":"Remove unnecessary <code>i == 0</code> checks from string building loops"}},{"before":null,"after":"a50b7502bfb13712cd6861d1be48f0c0ac93c0c7","ref":"refs/heads/devel","pushedAt":"2024-07-03T06:43:04.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"TV4Fun","name":"Joel Croteau","path":"/TV4Fun","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/4702728?s=80&v=4"},"commit":{"message":"Move string building loops in `VariantUtilityFunctions` into separate function\n\nActually, what would be even better than 0f77192203 would be to eliminate all\nof this code repetition and create a single function to join strings.\nThis also gives us a useful utility function for joining string representations\nof `Variant`s.","shortMessageHtmlLink":"Move string building loops in <code>VariantUtilityFunctions</code> into separate…"}},{"before":null,"after":"6680be10d19ce7b907ecdfb6312b1e0f1680bded","ref":"refs/heads/variant_join","pushedAt":"2024-07-03T06:20:21.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"TV4Fun","name":"Joel Croteau","path":"/TV4Fun","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/4702728?s=80&v=4"},"commit":{"message":"Move string building loops in `VariantUtilityFunctions` into separate function\n\nActually, what would be even better than 0f77192203 would be to eliminate all\nof this code repetition and create a single function to join strings.\nThis also gives us a useful utility function for joining string representations\nof `Variant`s.","shortMessageHtmlLink":"Move string building loops in <code>VariantUtilityFunctions</code> into separate…"}},{"before":"da8edac87ef581bbdfef2e3e74ed9f035759c23c","after":"5fcc1ce8dc662f0191955cf605bebd25be310d1d","ref":"refs/heads/master","pushedAt":"2024-07-03T04:47:36.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"TV4Fun","name":"Joel Croteau","path":"/TV4Fun","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/4702728?s=80&v=4"},"commit":{"message":"Remove unnecessary `i == 0` checks from string building loops\n\n`String` is auto-initialized to be empty and `String::operator+=`\n[already checks](https://github.com/godotengine/godot/blob/f0d15bbfdfde1c1076903afb7a7db373580d5534/core/string/ustring.cpp#L520)\nif it is empty before appending, so this check is pointless and just needlessly\nclutters the codebase.","shortMessageHtmlLink":"Remove unnecessary <code>i == 0</code> checks from string building loops"}},{"before":"0fa4ac19ad38c533d4f41c8e868185ec6f04f16d","after":"da8edac87ef581bbdfef2e3e74ed9f035759c23c","ref":"refs/heads/master","pushedAt":"2024-07-02T20:17:27.000Z","pushType":"push","commitsCount":73,"pusher":{"login":"TV4Fun","name":"Joel Croteau","path":"/TV4Fun","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/4702728?s=80&v=4"},"commit":{"message":"[Web] Remove unnecessary EMCC_FORCE_STDLIBS in dlink builds\n\nAs discussed with upstream, the C/C++ standard library is always fully\nincluded when building with MAIN_MODULE=1, so using EMCC_FORCE_STDLIBS\nis not necessary in our case.","shortMessageHtmlLink":"[Web] Remove unnecessary EMCC_FORCE_STDLIBS in dlink builds"}},{"before":"b40173e04359035f17eb736771763e6de49b9dc5","after":"0fa4ac19ad38c533d4f41c8e868185ec6f04f16d","ref":"refs/heads/master","pushedAt":"2024-06-28T07:20:54.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"TV4Fun","name":"Joel Croteau","path":"/TV4Fun","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/4702728?s=80&v=4"},"commit":{"message":"Fix Android and Web builds\n\nNeither Android's NDK nor Emscripten provide `backtrace` through `execinfo.h`.\nThere are other ways to get a stacktrace on these platforms, but I am not\nexpert enough to implement them, so leave them unimplemented for now.","shortMessageHtmlLink":"Fix Android and Web builds"}},{"before":"1e21798dc30aadb42532d9c16dc45212aa854ec1","after":"b40173e04359035f17eb736771763e6de49b9dc5","ref":"refs/heads/master","pushedAt":"2024-06-28T06:47:01.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"TV4Fun","name":"Joel Croteau","path":"/TV4Fun","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/4702728?s=80&v=4"},"commit":{"message":"Actual fix for Linux builds\n\nOkay, there doesn't actually seem to be a way to forward declare a `typedef`\nto an anonymous `struct`. So, rather than include an unnecessary system header\nin `os_unix.h`, I am now just passing the members of `Dl_info` individually.\nThis will be slightly less efficient, but this code is generally not called\nin performance-critical paths, and this should be clean, maintainable, and\nplatform-independent.","shortMessageHtmlLink":"Actual fix for Linux builds"}},{"before":"0b950f5cd4f3cf005ddc48098de365868c95b21b","after":"1e21798dc30aadb42532d9c16dc45212aa854ec1","ref":"refs/heads/master","pushedAt":"2024-06-28T06:17:58.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"TV4Fun","name":"Joel Croteau","path":"/TV4Fun","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/4702728?s=80&v=4"},"commit":{"message":"Try fix for Linux builds\n\nThe Linux build breaks on `OS_Unix` because `Dl_info` is not `typedef`ed as\n`struct dl_info`, so the forward declaration of that struct breaks. Changing\nthe forward declaration to `struct Dl_info` breaks the Mac build though, so\nthat leaves us with some `#ifdef`s. This may or may not work, I'll have to see.","shortMessageHtmlLink":"Try fix for Linux builds"}},{"before":"1a75580d752ef22e911c0b8de7ead2b3f2ac5aac","after":"0b950f5cd4f3cf005ddc48098de365868c95b21b","ref":"refs/heads/master","pushedAt":"2024-06-28T04:51:30.000Z","pushType":"push","commitsCount":3,"pusher":{"login":"TV4Fun","name":"Joel Croteau","path":"/TV4Fun","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/4702728?s=80&v=4"},"commit":{"message":"Move platform dependent code into `OS` class and fix stacktrace from scripts","shortMessageHtmlLink":"Move platform dependent code into <code>OS</code> class and fix stacktrace from …"}},{"before":"374807f427eec5ee7caebfc509a158fe715a6bfe","after":"1a75580d752ef22e911c0b8de7ead2b3f2ac5aac","ref":"refs/heads/master","pushedAt":"2024-06-27T05:13:57.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"TV4Fun","name":"Joel Croteau","path":"/TV4Fun","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/4702728?s=80&v=4"},"commit":{"message":"Make `push_error` and `push_warning` print name of calling function\n\nCurrently, `push_error` and `push_warning` give themselve as the calling\nfunction, which is not useful for debugging. I have altered these to use the\nC stacktrace to get the name of the function that called them. This saves\nhaving to turn these functions into macros, which would require recompiling\nevery single piece of code that uses them. I have also set it to, when debug\nsymbols are available, use them with `atos` (available on macOS) to find the\nexact source file and line being called from. It should be possible to the same\nthing on Linux using `addr2line`, but I don't have a Linux box handy to test\nthat. I am not sure how you would implement this in Windows.\n\nI have tested this on macOS Sonoma 14.5 (23F79). It should work on any *nix\nsystem. I am not sure about Windows.\n\nFixes #76770","shortMessageHtmlLink":"Make <code>push_error</code> and <code>push_warning</code> print name of calling function"}}],"hasNextPage":false,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAAEdnWM5wA","startCursor":null,"endCursor":null}},"title":"Activity · TV4Fun/godot"}