Skip to content
This repository has been archived by the owner on Oct 28, 2024. It is now read-only.

[DOCS] Improve docs on using composer patch #401

Merged
merged 1 commit into from
Oct 11, 2024

Conversation

kanow
Copy link
Contributor

@kanow kanow commented Oct 10, 2024

Add note to use composer-exit-on-patch-failure to get notice about an error on patching.

Add note to use `composer-exit-on-patch-failure` to get notice about an error on patching.
@froemken
Copy link

Patch is OK for me, but composer-patches is currently working on Version 2.0. Current release is BETA-2, where this option is activated by default:

cweagans/composer-patches#164

Further the configuration will be renamed, because of the required configuration package: exit-on-patch-failure. With this change also the ENV var will change to: COMPOSER_PATCHES_EXIT_ON_PATCH_FAILURE.

Maybe it would be good to add a hint, that this config-variable is only for the 1.x branch of composer-patches.

With version 2 the exit-on-failor is the new default.

For version 1 the error will also be shown, but as composer still processes the other requirements, the error will be somewhere above all the other output. With exit-on-failor the composer process will stop immediately. So the Otherwise, you may not notice the error. means the error message is somewhere above all the other composer output, if this setting is not explicit activated.

@sfroemkenjw
Copy link

Hi @kanow

thank you for providing that patch. We will take care about the update, if composer-patches releases version 2.

Stefan

@sfroemkenjw sfroemkenjw merged commit 6db655a into TYPO3-Documentation:12.4 Oct 11, 2024
1 check passed
@linawolf
Copy link
Member

@kanow Thanks a lot for your first time contribution!

If possible try to make your changes on the "main" branch next time. We have an automatic workflow to backport them on the 12.4 branch for you.

linawolf pushed a commit that referenced this pull request Oct 11, 2024
Add note to use `composer-exit-on-patch-failure` to get notice about an error on patching.
sfroemkenjw pushed a commit that referenced this pull request Oct 11, 2024
Add note to use `composer-exit-on-patch-failure` to get notice about an error on patching.

Co-authored-by: Karsten Nowak <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants