Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configurable request header property for matching with the hostname for sites #348

Open
kubilaymelnikov opened this issue Jan 17, 2025 · 3 comments

Comments

@kubilaymelnikov
Copy link

Our hosting provider does not pass the original host to the Node server.
This is why we need to perform the matching and assignment using a different value in the header.
I would like to contribute this in case someone else might need this setting in the future.

@kubilaymelnikov kubilaymelnikov changed the title Configurable request header for matching with the hostname for sites Configurable request header property for matching with the hostname for sites Jan 17, 2025
kubilaymelnikov pushed a commit to kubilaymelnikov/nuxt-typo3 that referenced this issue Jan 20, 2025
@kubilaymelnikov
Copy link
Author

Hello @mercs600,

I’m having trouble testing my changes. I can’t install my branch from GitHub because of an issue with the prepack script.

To address this (temporarily), I extended the script with pnpm dev:prepare which allows me to proceed one step further. However, I’m now encountering a syntax error that I can’t investigate at the moment.

_71f86719baf84b7767830130dd30c672 prepack: [error] Unexpected token (13:12) in /home/runner/setup-pnpm/node_modules/.bin/store/v3/tmp/_tmp_1807_71f86719baf84b7767830130dd30c672/src/module.ts

I’ve created a workaround for now to address our issue, and I’ll revisit it as soon as I have more time. In the meantime, feel free to let me know if you want to proceed with this at all.

@mercs600
Copy link
Contributor

Hello @kubilaymelnikov, thank you for your insight.
We will discuss internally whether we want this option to be configurable or not, and we will also check what is going on with the installation—probably we did not update after some recent Nuxt changes.

@kubilaymelnikov
Copy link
Author

Hello @mercs600, if you don’t consider it sensible to include this configuration, I would close this issue and delete my feature branch. Our hosting provider adjusted the Vhost configuration at our request.
The reason I wanted to implement this was out of necessity because the host suddenly stopped being passed to the Node instance. This is now working again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants