chore(page): change section stream type from PageSection to PageSecti… (#4167)

* chore(page): change section stream type from PageSection to PageSectionCreated

* update: ui

* [autofix.ci] apply automated fixes

---------

Co-authored-by: liangfung <[email protected]>
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>

Author: 3 people

ee/tabby-schema/graphql/schema.graphql

@@ -972,13 +972,23 @@ type PageSectionContentDelta {
   delta: String!
 }
 
+type PageSectionCreated {
+  id: ID!
+  pageId: ID!
+  title: String!
+  position: Int!
+  createdAt: DateTime!
+  updatedAt: DateTime!
+  debugData: PageSectionDebugData
+}
+
 type PageSectionDebugData {
   "Messages sent to LLM to generate the page section titles."
   generateSectionTitlesMessages: [ChatCompletionMessage!]!
 }
 
 type PageSectionsCreated {
-  sections: [PageSection!]!
+  sections: [PageSectionCreated!]!
   debugData: PageSectionDebugData
 }
 
@@ -1330,7 +1340,7 @@ union MessageAttachmentDoc = MessageAttachmentWebDoc | MessageAttachmentIssueDoc
 union PageRunItem = PageCreated | PageContentDelta | PageContentCompleted | PageSectionsCreated | PageSectionAttachmentCodeFileList | PageSectionAttachmentCode | PageSectionAttachmentDoc | PageSectionContentDelta | PageSectionContentCompleted | PageCompleted
 
 "Schema of page convert stream."
-union SectionRunItem = PageSection | PageSectionAttachmentCodeFileList | PageSectionAttachmentCode | PageSectionAttachmentDoc | PageSectionContentDelta | PageSectionContentCompleted
+union SectionRunItem = PageSectionCreated | PageSectionAttachmentCodeFileList | PageSectionAttachmentCode | PageSectionAttachmentDoc | PageSectionContentDelta | PageSectionContentCompleted
 
 """
   Schema of thread run stream.

ee/tabby-schema/src/schema/page/types.rs

@@ -201,10 +201,38 @@ pub struct PageSectionDebugData {
     pub generate_section_titles_messages: Vec<ChatCompletionMessage>,
 }
 
+#[derive(GraphQLObject, Clone)]
+#[graphql(context = Context)]
+pub struct PageSectionCreated {
+    pub id: ID,
+    pub page_id: ID,
+    pub title: String,
+    pub position: i32,
+
+    pub created_at: DateTime<Utc>,
+    pub updated_at: DateTime<Utc>,
+
+    pub debug_data: Option<PageSectionDebugData>,
+}
+
+impl From<PageSection> for PageSectionCreated {
+    fn from(value: PageSection) -> Self {
+        Self {
+            id: value.id,
+            page_id: value.page_id,
+            title: value.title,
+            position: value.position,
+            created_at: value.created_at,
+            updated_at: value.updated_at,
+            debug_data: None,
+        }
+    }
+}
+
 #[derive(GraphQLObject, Clone)]
 #[graphql(context = Context)]
 pub struct PageSectionsCreated {
-    pub sections: Vec<PageSection>,
+    pub sections: Vec<PageSectionCreated>,
 
     pub debug_data: Option<PageSectionDebugData>,
 }
@@ -365,7 +393,7 @@ pub enum PageRunItem {
 #[derive(GraphQLUnion)]
 #[graphql(context = Context)]
 pub enum SectionRunItem {
-    PageSectionCreated(PageSection),
+    PageSectionCreated(PageSectionCreated),
 
     PageSectionAttachmentCodeFileList(PageSectionAttachmentCodeFileList),
     PageSectionAttachmentCode(PageSectionAttachmentCode),

ee/tabby-ui/app/pages/components/page-main.tsx

@@ -193,7 +193,16 @@ export function Page() {
   ) => {
     if (!debugData || !sectionId) return
     setDebugData(prev => {
-      if (!prev) return prev
+      if (!prev) {
+        return {
+          sections: [
+            {
+              id: sectionId,
+              ...debugData
+            }
+          ]
+        }
+      }
 
       const sections = prev.sections || []
       let target = sections.find(s => s.id === sectionId)
@@ -412,7 +421,7 @@ export function Page() {
     data: CreatePageSectionRunSubscription['createPageSectionRun']
   ) => {
     switch (data.__typename) {
-      case 'PageSection': {
+      case 'PageSectionCreated': {
         const { id, title, position } = data
         setCurrentSectionId(id)
         setPendingSectionIds(new Set([id]))

ee/tabby-ui/app/pages/lib/query.ts

@@ -27,22 +27,6 @@ export const createThreadToPageRunSubscription = graphql(/* GraphQL */ `
           id
           position
           title
-          attachments {
-            code {
-              __typename
-              gitUrl
-              commit
-              filepath
-              language
-              content
-              startLine
-            }
-            codeFileList {
-              __typename
-              fileList
-              truncated
-            }
-          }
         }
         debugData {
           __typename
@@ -193,22 +177,6 @@ export const createPageRunSubscription = graphql(/* GraphQL */ `
           id
           position
           title
-          attachments {
-            code {
-              __typename
-              gitUrl
-              commit
-              filepath
-              language
-              content
-              startLine
-            }
-            codeFileList {
-              __typename
-              fileList
-              truncated
-            }
-          }
         }
         debugData {
           __typename
@@ -329,7 +297,7 @@ export const createPageSectionRunSubscription = graphql(/* GraphQL */ `
   subscription createPageSectionRun($input: CreatePageSectionRunInput!) {
     createPageSectionRun(input: $input) {
       __typename
-      ... on PageSection {
+      ... on PageSectionCreated {
         id
         title
         position

ee/tabby-ui/lib/tabby/gql.ts

@@ -146,7 +146,8 @@ const client = new Client({
         PageSectionContentCompleted: () => null,
         PageSectionAttachmentCode: () => null,
         PageSectionAttachmentDoc: () => null,
-        SectionAttachment: () => null
+        SectionAttachment: () => null,
+        PageSectionCreated: () => null
       },
       resolvers: {
         Query: {

ee/tabby-webserver/src/service/page.rs

@@ -204,7 +204,7 @@ impl PageService for PageServiceImpl {
                     generate_section_titles_messages: messages,
                 });
             }
-            yield Ok(SectionRunItem::PageSectionCreated(section_from_db));
+            yield Ok(SectionRunItem::PageSectionCreated(section_from_db.into()));
 
             let mut attachments_stream = generate_section_with_attachments(
                 debug_option.as_ref(),
@@ -445,7 +445,7 @@ impl PageServiceImpl {
             let mut page_sections = Vec::new();
             for section_title in &page_section_titles {
                 let section = db.create_page_section(page_id.as_rowid()?, section_title).await?;
-                page_sections.push(section_from_db(auth.clone(), section).await);
+                page_sections.push(section_from_db(auth.clone(), section).await.into());
             }
 
             yield Ok(PageRunItem::PageSectionsCreated(PageSectionsCreated {