From 07b68ae0bff42aecc57fcf5f9420ff9715f8f1f2 Mon Sep 17 00:00:00 2001 From: Bibash Shrestha Date: Fri, 15 Mar 2024 12:41:48 +0545 Subject: [PATCH] refactor: Handle .vc for all --- lib/scan/cubit/scan_cubit.dart | 13 ++----------- .../lib/credential_manifest.dart | 1 - .../helpers/get_ebsi_v3_compatible_filter_list.dart | 13 ------------- 3 files changed, 2 insertions(+), 25 deletions(-) delete mode 100644 packages/credential_manifest/lib/src/helpers/get_ebsi_v3_compatible_filter_list.dart diff --git a/lib/scan/cubit/scan_cubit.dart b/lib/scan/cubit/scan_cubit.dart index 80885b2e2..6e6829e34 100644 --- a/lib/scan/cubit/scan_cubit.dart +++ b/lib/scan/cubit/scan_cubit.dart @@ -974,21 +974,12 @@ class ScanCubit extends Cubit { in presentationDefinition.inputDescriptors) { final filterList = inputDescriptor.constraints?.fields ?? []; - /// There is issue in EBSI conformance test which for modification of filterList - /// We apply this rule only with EBSI v3 profile - final List compatibleFilterList = - profileCubit.state.model.profileType != ProfileType.ebsiV3 - ? List.from(filterList) - : getEbsiV3CompatibleFilterList(filterList); final credential = getCredentialsFromFilterList( - filterList: compatibleFilterList, + filterList: filterList, credentialList: [credentialsToBePresented[i]], ); - final pathNested = { - 'id': inputDescriptor.id, - 'format': vcFormat, - }; + final pathNested = {'id': inputDescriptor.id, 'format': vcFormat}; if (credential.isNotEmpty) { if (credentialsToBePresented.length == 1) { diff --git a/packages/credential_manifest/lib/credential_manifest.dart b/packages/credential_manifest/lib/credential_manifest.dart index d7029e6a3..b0db099d7 100644 --- a/packages/credential_manifest/lib/credential_manifest.dart +++ b/packages/credential_manifest/lib/credential_manifest.dart @@ -4,7 +4,6 @@ library credential_manifest; export 'src/credential_manifest.dart'; export 'src/helpers/get_color_from_credential.dart'; export 'src/helpers/get_credential_manifest.dart'; -export 'src/helpers/get_ebsi_v3_compatible_filter_list.dart'; export 'src/helpers/get_text_from_credential.dart'; export 'src/models/color_object.dart'; export 'src/models/constraints.dart'; diff --git a/packages/credential_manifest/lib/src/helpers/get_ebsi_v3_compatible_filter_list.dart b/packages/credential_manifest/lib/src/helpers/get_ebsi_v3_compatible_filter_list.dart deleted file mode 100644 index 012527e13..000000000 --- a/packages/credential_manifest/lib/src/helpers/get_ebsi_v3_compatible_filter_list.dart +++ /dev/null @@ -1,13 +0,0 @@ -import 'package:credential_manifest/credential_manifest.dart'; - -List getEbsiV3CompatibleFilterList(List filterList) { - final List newList = []; - for (int i = 0; i < filterList.length; i++) { - final List newPath = []; - for (final element in filterList[i].path) { - newPath.add(element.replaceAll('.vc', '')); - } - newList[i] = filterList[i].copyWith(path: newPath); - } - return newList; -}