Skip to content

Commit 507c924

Browse files
committed
refacor: 修改方法命名,避免歧义
1 parent 309d1d0 commit 507c924

File tree

4 files changed

+5
-5
lines changed

4 files changed

+5
-5
lines changed

src/main/java/io/github/talelin/latticy/mapper/GroupMapper.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ public interface GroupMapper extends BaseMapper<GroupDO> {
2020
* @param userId 用户id
2121
* @return 所有分组
2222
*/
23-
List<GroupDO> selectUserGroups(@Param("userId") Integer userId);
23+
List<GroupDO> selectGroupsByUserId(@Param("userId") Integer userId);
2424

2525
/**
2626
* 获得用户的所有分组id

src/main/java/io/github/talelin/latticy/service/impl/GroupServiceImpl.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ public class GroupServiceImpl extends ServiceImpl<GroupMapper, GroupDO> implemen
3636

3737
@Override
3838
public List<GroupDO> getUserGroupsByUserId(Integer userId) {
39-
return this.baseMapper.selectUserGroups(userId);
39+
return this.baseMapper.selectGroupsByUserId(userId);
4040
}
4141

4242
@Override

src/main/resources/mapper/GroupMapper.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
</resultMap>
1515

1616

17-
<select id="selectUserGroups" parameterType="java.lang.Integer" resultMap="BaseResultMap">
17+
<select id="selectGroupsByUserId" parameterType="java.lang.Integer" resultMap="BaseResultMap">
1818
SELECT g.id, g.name, g.info,g.level,
1919
g.create_time,g.update_time,g.delete_time
2020
from lin_group AS g

src/test/java/io/github/talelin/latticy/mapper/GroupMapperTest.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ public class GroupMapperTest {
3333
private UserGroupMapper userGroupMapper;
3434

3535
@Test
36-
public void selectUserGroups() {
36+
public void selectGroupsByUserId() {
3737
String email = "[email protected]";
3838
String username = "pedro-test";
3939
UserDO user = new UserDO();
@@ -46,7 +46,7 @@ public void selectUserGroups() {
4646

4747
userGroupMapper.insert(new UserGroupDO(user.getId(), group.getId()));
4848

49-
List<GroupDO> groups = groupMapper.selectUserGroups(user.getId());
49+
List<GroupDO> groups = groupMapper.selectGroupsByUserId(user.getId());
5050
boolean anyMatch = groups.stream().anyMatch(it -> it.getName().equals("group"));
5151
assertTrue(anyMatch);
5252
}

0 commit comments

Comments
 (0)