You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I noticed that the build setup for @tanstack/query-eslint-plugin was switched from tsup to Vite, and I was curious about the reasoning behind that choice — particularly since ESLint plugins are running inside Node.js environment, not in browser.
When I opened #8878, I hit a error when building after importing modules from typescript — I assume Vite failed to handle the Node-specific usage, which led me to suspect that Vite might not be the ideal tool for building Node-targeted libraries like ESLint plugins.
So my question is - What were the motivating factors behind choosing Vite instead of sticking with tsup? Was it for dev experience, consistency with other packages, or something else?
reacted with thumbs up emoji reacted with thumbs down emoji reacted with laugh emoji reacted with hooray emoji reacted with confused emoji reacted with heart emoji reacted with rocket emoji reacted with eyes emoji
-
Hey everyone 👋
I noticed that the build setup for
@tanstack/query-eslint-plugin
was switched fromtsup
to Vite, and I was curious about the reasoning behind that choice — particularly since ESLint plugins are running inside Node.js environment, not in browser.When I opened #8878, I hit a error when building after importing modules from
typescript
— I assume Vite failed to handle the Node-specific usage, which led me to suspect that Vite might not be the ideal tool for building Node-targeted libraries like ESLint plugins.So my question is - What were the motivating factors behind choosing Vite instead of sticking with tsup? Was it for dev experience, consistency with other packages, or something else?
just hoping to understand the tradeoffs better 🙏
Thanks!
Beta Was this translation helpful? Give feedback.
All reactions