Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(react-virtual): handle scrollElement cleanup after HMR #820

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(react-virtual): handle scrollElement cleanup after HMR #820

wants to merge 1 commit into from
+4 −0

Conversation

hophiphip
Copy link

@hophiphip hophiphip commented Aug 30, 2024 •
edited
Loading

When HMR is triggered useEffect cleanup function will call function returned from instance._didMount().
This will set scrollElement to null and Virtualizer will stop working.

I added an additional check if scrollElement is null and if it is - call instance._willUpdate().

This PR resolves #750.

@hophiphip hophiphip mentioned this pull request Aug 30, 2024
Open
2 tasks
@hophiphip hophiphip changed the title fix: handle scrollElement cleanup on HMR fix: handle scrollElement cleanup after HMR Aug 30, 2024
@hophiphip hophiphip changed the title fix: handle scrollElement cleanup after HMR fix(react-virtual): handle scrollElement cleanup after HMR Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Innei Innei Innei approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

HMR (live reload, fast refresh) broke render in React
2 participants
@hophiphip @Innei