-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Truncated answers #29
Comments
yes of course
Il giorno gio 21 mag 2020 alle ore 08:11 bobzomer <[email protected]>
ha scritto:
… We use CoAPthon3 to communicate with Philips air purifier (see
https://github.com/rgerganov/py-air-control/). In some cases, with some
models, the CoAP answer is truncated by the library.
We can see in coapthon/client/coap.py, line 239, method receive_datagram:
datagram, addr = self._socket.recvfrom(1152)
I've cloned the CoAPthon3 library and modified this line to:
datagram, addr = self._socket.recvfrom(1500)
And now it works properly.
I will make a PR. Would you think possible to accept it and update pip
package accordingly?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#29>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABTPN6UYQLIXAV64P3V45CTRSTAZTANCNFSM4NGSLLJA>
.
|
Any plans to release a new PyPI version with this fix? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
We use CoAPthon3 to communicate with Philips air purifier (see https://github.com/rgerganov/py-air-control/). In some cases, with some models, the CoAP answer is truncated by the library.
We can see in
coapthon/client/coap.py
, line 239, methodreceive_datagram
:I've cloned the CoAPthon3 library and modified this line to:
And now it works properly.
I will make a PR. Would you think possible to accept it and update pip package accordingly?
The text was updated successfully, but these errors were encountered: