Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Script feedback #14

Open
ghost opened this issue Oct 8, 2019 · 2 comments
Open

Script feedback #14

ghost opened this issue Oct 8, 2019 · 2 comments
Labels
✨ enhancement New feature or request

Comments

@ghost
Copy link

ghost commented Oct 8, 2019

I see you're using the Script DOM Element approach to script tag injection in the Script example. While that's good and well it feels a bit kludgy given Fetch hasn't implemented yet and, using Fetch, you could handle a more general use case covering both Script and Styles with additional control and without the need to promisfy the synchronous code written.

Given many of the other APIs exposed in this project are highly UA dependent (e.g. Battery Status) and likely to be unreliable – surprisingly given the website suggests "graceful degradation" and I can't use the clipboard on known working devices – please consider reworking Script to use Fetch Injection to support Style injection in addition to adding extensibility using modern standards under a more declarative approach. Cheers.

@logaretm logaretm added the ✨ enhancement New feature or request label Oct 8, 2019
@logaretm
Copy link
Collaborator

logaretm commented Oct 8, 2019

Thanks for the suggestion, would you be interested in PRing this?

surprisingly given the website suggests "graceful degradation"

Well, this is still in the early stages, some APIs might need some alternatives or polyfills, but "graceful degradation" is a goal of this library.

@ghost
Copy link
Author

ghost commented Oct 9, 2019

It would be my pleasure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant