Skip to content

Commit 0b27e53

Browse files
authored
Merge pull request #202 from TaskFlow-CLAP/CLAP-446
CLAP-446 QA 사항 반영 Tony.tsx 3차
2 parents b70ecfa + 14678e7 commit 0b27e53

20 files changed

+65
-113
lines changed

src/components/common/EditInformation.vue

Lines changed: 21 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
<ModalView
1111
:isOpen="isWarnningModalVisible"
1212
:type="'warningType'"
13-
@click="changePw"
13+
@click="modalTarget === 'pw' ? changePw() : router.back()"
1414
@close="warningModalToggle">
1515
<template #header>정보가 저장되지 않았습니다</template>
1616
<template #body>수정 사항을 삭제하고 이동하시겠습니까?</template>
@@ -196,17 +196,33 @@ const validateName = () => {
196196
})
197197
}
198198
}
199-
const handleCancel = () => {
200-
router.back()
201-
}
202199
203-
const handlePwChange = () => {
200+
const checkChange = () => {
204201
if (
205202
selectedFile.value ||
206203
info.value.name != name.value ||
207204
info.value.notificationSettingInfo.kakaoWork != kakaoWorkCheck.value ||
208205
info.value.notificationSettingInfo.email != emailCheck.value
209206
) {
207+
return true
208+
} else {
209+
return false
210+
}
211+
}
212+
213+
const modalTarget = ref('')
214+
const handleCancel = () => {
215+
if (checkChange()) {
216+
modalTarget.value = 'cancel'
217+
warningModalToggle()
218+
} else {
219+
router.back()
220+
}
221+
}
222+
223+
const handlePwChange = () => {
224+
if (checkChange()) {
225+
modalTarget.value = 'pw'
210226
warningModalToggle()
211227
} else {
212228
changePw()

src/components/common/ModalView.vue

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,7 @@
7272
type="button"
7373
class="button-large-red"
7474
@click="confirmModal">
75-
{{ type === 'inputType' ? '반려' : type === 'terminate' ? '종료' : '삭제' }}
75+
{{ type === 'inputType' ? '반려' : type === 'terminate' ? '종료' : '확인' }}
7676
</button>
7777
</div>
7878
</div>

src/components/lists/ListCardTab.vue

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -3,11 +3,10 @@
33
class="flex gap-2 items-center"
44
:style="{ width: width ? `${width}px` : '' }"
55
:class="width ? 'shrink-0' : 'grow'">
6-
<div
7-
v-if="profileImg"
8-
class="w-6 h-6 rounded-full overflow-hidden">
9-
<img :src="profileImg" />
10-
</div>
6+
<ImageContainer
7+
v-if="profileImg !== undefined && content"
8+
:size="24"
9+
:url="profileImg" />
1110
<TaskStatus
1211
v-if="isStatus"
1312
:status="content as Status" />
@@ -23,9 +22,8 @@
2322
<script setup lang="ts">
2423
import type { ListCardProps, Status } from '@/types/common'
2524
import TaskStatus from '../common/TaskStatus.vue'
25+
import ImageContainer from '../common/ImageContainer.vue'
2626
2727
const { content, width, isTextXs, profileImg, isStatus, isStatusCode, isTextBody } =
2828
defineProps<ListCardProps>()
2929
</script>
30-
31-
<style scoped></style>

src/components/member-management/MemberManagementListCard.vue

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@
2121
@click="toggleModal('delete')">
2222
삭제
2323
</button>
24-
<div class="relative">
24+
<div class="relative h-full max-h-[34px]">
2525
<button
2626
type="button"
2727
:class="

src/components/my-request/MyRequestListCard.vue

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ const myRequestTabList: ListCardProps[] = [
4747
{ content: info.mainCategoryName, width: 80 },
4848
{ content: info.categoryName, width: 80 },
4949
{ content: info.title },
50-
{ content: info.processorName, width: 120, profileImg: info.processorImg },
50+
{ content: info.processorName, width: 120, profileImg: info.processorImg || '' },
5151
{ content: info.taskStatus, width: 80, isStatus: true },
5252
{ content: info.finishedAt ? formatDate(info.finishedAt) : '', width: 80 }
5353
]

src/components/my-task/MyTaskListCard.vue

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ const myRequestTabList: ListCardProps[] = [
4646
{ content: info.mainCategoryName, width: 80 },
4747
{ content: info.categoryName, width: 80 },
4848
{ content: info.title },
49-
{ content: info.requesterName, width: 120, profileImg: info.requesterImg },
49+
{ content: info.requesterName, width: 120, profileImg: info.requesterUrl || '' },
5050
{ content: info.taskStatus, width: 80, isStatus: true },
5151
{ content: info.finishedAt ? formatDate(info.finishedAt) : '', width: 80 }
5252
]

src/components/request-approve/ManagerDropdown.vue

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@
1818
@click="toggleDropdown">
1919
<div class="flex gap-2 items-center">
2020
<ImageContainer
21+
v-if="isInvalidateState === 'manager' || modelValue?.imageUrl"
2122
:size="24"
2223
:url="modelValue?.imageUrl" />
2324
<p :class="{ 'text-disabled': !modelValue }">
@@ -44,7 +45,7 @@
4445
{{ option.nickname }}
4546
</p>
4647
</div>
47-
<p class="text-primary1 text-xs">잔여 작업 : {{ option.remainingTasks }}</p>
48+
<p class="text-primary1 text-xs font-semibold">잔여 작업 : {{ option.remainingTasks }}</p>
4849
</div>
4950
</div>
5051
</div>

src/components/request-history/RequestHistoryListCard.vue

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -46,8 +46,8 @@ const myRequestTabList: ListCardProps[] = [
4646
{ content: info.mainCategoryName, width: 80 },
4747
{ content: info.categoryName, width: 80 },
4848
{ content: info.title },
49-
{ content: info.requesterName, width: 120, profileImg: info.requesterImg },
50-
{ content: info.processorName, width: 120, profileImg: info.processorImg },
49+
{ content: info.requesterName, width: 120, profileImg: info.requesterUrl || '' },
50+
{ content: info.processorName, width: 120, profileImg: info.processorUrl || '' },
5151
{ content: info.taskStatus, width: 80, isStatus: true },
5252
{ content: info.finishedAt ? formatDate(info.finishedAt) : '', width: 80 }
5353
]

src/components/request-task/RequestTaskDropdown.vue

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
class="relative flex">
1111
<div
1212
class="flex w-full h-11 items-center rounded p-4 border border-border-1"
13-
:class="disabled ? 'bg-background-1 text-disabled' : 'bg-white cursor-pointer'"
13+
:class="disabled ? 'bg-background-2 text-disabled' : 'bg-white cursor-pointer'"
1414
@click="!disabled && toggleDropdown()">
1515
<p :class="{ 'text-disabled': modelValue === placeholderText }">
1616
{{ modelValue || placeholderText }}

src/components/request-task/RequestTaskFileInputAfter.vue

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@
3232
</div>
3333
<label
3434
for="file"
35-
class="w-full h-8 flex items-center justify-center text-primary1 font-semibold gap-1 text-xs cursor-pointer shrink-0">
35+
class="w-full h-8 flex items-center justify-center text-primary1 font-semibold gap-1 text-xs cursor-pointer shrink-0 hover:bg-background-2">
3636
<CommonIcons
3737
:name="plusIcon"
3838
:style="{ fill: '#7879eb' }" />

0 commit comments

Comments
 (0)