♻️ [refactor] 글로벌 오류 핸들링에 따른 불필요한 try..catch문 삭제

seorang42 · seorang42 · commit fecd55f801cf · 2025-02-12T15:38:46.000+09:00
diff --git a/src/components/common/EditInformation.vue b/src/components/common/EditInformation.vue
@@ -3,7 +3,7 @@
     <ModalView
       :isOpen="isModalVisible"
       :type="'successType'"
-      @close="handleCancel">
+      @close="isModalVisible = !isModalVisible">
       <template #header>정보가 수정되었습니다</template>
     </ModalView>
 
@@ -288,13 +288,8 @@ const handleSubmit = async () => {
       selectedFile.value = null
     }
 
-    try {
-      await patchEditInfo(formData)
-      isModalVisible.value = true
-      await memberStore.updateMemberInfoWithToken()
-    } catch (error) {
-      console.error('요청 실패:', error)
-    }
+    await patchEditInfo(formData)
+    isModalVisible.value = true
   }
 }
 </script>
diff --git a/src/components/member-management/MemberManagementListCard.vue b/src/components/member-management/MemberManagementListCard.vue
@@ -96,16 +96,10 @@ const closeModal = () => {
 }
 
 const onMemberDelete = async (memberId: number) => {
-  try {
-    await axiosInstance.delete(`/api/managements/members`, { data: { memberId } })
-    resultModalType.value = 'successType'
-    message.value = '회원을 삭제했습니다'
-    toggleModal('result')
-  } catch {
-    resultModalType.value = 'failType'
-    message.value = '회원 삭제에 실패했습니다'
-    toggleModal('result')
-  }
+  await axiosInstance.delete(`/api/managements/members`, { data: { memberId } })
+  resultModalType.value = 'successType'
+  message.value = '회원을 삭제했습니다'
+  toggleModal('result')
 }
 
 const onMemberInvite = async (memberId: number) => {
diff --git a/src/components/request-approve/RequestApprove.vue b/src/components/request-approve/RequestApprove.vue
@@ -165,11 +165,7 @@ const handleSubmit = async () => {
       : null,
     labelId: approveData.value.label?.labelId || null
   }
-  try {
-    await postTaskApprove(requestId, requestData)
-    isModalVisible.value = true
-  } catch (error) {
-    console.error('API 요청 실패:', error)
-  }
+  await postTaskApprove(requestId, requestData)
+  isModalVisible.value = true
 }
 </script>
diff --git a/src/components/request-task/ReRequestTask.vue b/src/components/request-task/ReRequestTask.vue
@@ -127,6 +127,9 @@ const handleSubmit = async () => {
     isInvalidate.value = 'description'
     return
   }
+
+  isSubmitting.value = true
+
   const formData = new FormData()
 
   const attachmentsToDelete = initFileArr.value
@@ -168,9 +171,6 @@ const handleSubmit = async () => {
       await patchTaskRequest(id, formData)
     }
     isModalVisible.value = 'success'
-  } catch (e) {
-    isModalVisible.value = 'fail'
-    console.error('요청 실패:', e)
   } finally {
     isSubmitting.value = false
   }
diff --git a/src/components/request-task/RequestTask.vue b/src/components/request-task/RequestTask.vue
@@ -142,9 +142,6 @@ const handleSubmit = async () => {
   try {
     await postTaskRequest(formData)
     isModalVisible.value = 'success'
-  } catch (e) {
-    console.error(e)
-    isModalVisible.value = 'fail'
   } finally {
     isSubmitting.value = false
   }
diff --git a/src/components/request-task/RequestTaskDropdown.vue b/src/components/request-task/RequestTaskDropdown.vue
@@ -3,7 +3,7 @@
     <div class="flex text-xs text-red-1 gap-x-1 mb-2">
       <p class="text-body font-bold">{{ labelName }}</p>
       <p v-if="!isLabel">*</p>
-      <p v-if="!isInvalidate">카테고리를 선택해주세요</p>
+      <p v-if="isInvalidate">카테고리를 선택해주세요</p>
     </div>
     <div
       ref="htmlRef"
diff --git a/src/components/requested/RequestedListCard.vue b/src/components/requested/RequestedListCard.vue
@@ -108,13 +108,8 @@ const rejectRequest = async () => {
     modalError.value = '반려 사유를 입력해주세요'
     return
   }
-  try {
-    await axiosInstance.patch(`/api/tasks/${info.taskId}/terminate`, rejectReason)
-    toggleModal('success')
-  } catch {
-    toggleModal('fail')
-    modalError.value = '작업 반려에 실패했습니다'
-  }
+  await axiosInstance.patch(`/api/tasks/${info.taskId}/terminate`, rejectReason)
+  toggleModal('success')
 }
 
 const { info: userInfo } = useMemberStore()
diff --git a/src/components/task-detail/TaskDetailRight.vue b/src/components/task-detail/TaskDetailRight.vue
@@ -113,14 +113,10 @@ const newManager = ref(selectedManager.value)
 
 watch(newManager, async newValue => {
   if (newValue?.nickname !== selectedManager.value.nickname && newValue) {
-    try {
-      await changeProcessor(data.taskId, newValue.memberId)
-      selectedManager.value = newValue
-      queryClient.invalidateQueries({ queryKey: ['historyData', data.taskId] })
-      queryClient.invalidateQueries({ queryKey: ['taskDetailUser', data.taskId] })
-    } catch (error) {
-      console.error('Error updating processor', error)
-    }
+    await changeProcessor(data.taskId, newValue.memberId)
+    selectedManager.value = newValue
+    queryClient.invalidateQueries({ queryKey: ['historyData', data.taskId] })
+    queryClient.invalidateQueries({ queryKey: ['taskDetailUser', data.taskId] })
   }
 })
 </script>
diff --git a/src/components/task-detail/TaskStatusList.vue b/src/components/task-detail/TaskStatusList.vue
@@ -94,17 +94,12 @@ const rejectRequest = async () => {
     modalError.value = '종료 사유를 입력해주세요'
     return
   }
-  try {
-    await axiosInstance.patch(`/api/tasks/${taskId}/terminate`, rejectReason)
-    toggleModal('success')
-    emit('update:status', 'TERMINATED')
-    currentStatus.value = 'TERMINATED'
-    queryClient.invalidateQueries({ queryKey: ['taskDetailUser', taskId] })
-    queryClient.invalidateQueries({ queryKey: ['historyData', taskId] })
-  } catch {
-    toggleModal('fail')
-    modalError.value = '작업 종료에 실패했습니다'
-  }
+  await axiosInstance.patch(`/api/tasks/${taskId}/terminate`, rejectReason)
+  toggleModal('success')
+  emit('update:status', 'TERMINATED')
+  currentStatus.value = 'TERMINATED'
+  queryClient.invalidateQueries({ queryKey: ['taskDetailUser', taskId] })
+  queryClient.invalidateQueries({ queryKey: ['historyData', taskId] })
 }
 
 const changeStatus = async (newStatus: Status) => {
@@ -116,14 +111,10 @@ const changeStatus = async (newStatus: Status) => {
     return
   } else {
     emit('update:status', newStatus)
-    try {
-      currentStatus.value = newStatus
-      await patchChangeStatus(taskId || 0, newStatus)
-      queryClient.invalidateQueries({ queryKey: ['taskDetailUser', taskId] })
-      queryClient.invalidateQueries({ queryKey: ['historyData', taskId] })
-    } catch (error) {
-      console.error('Failed to update status:', error)
-    }
+    currentStatus.value = newStatus
+    await patchChangeStatus(taskId || 0, newStatus)
+    queryClient.invalidateQueries({ queryKey: ['taskDetailUser', taskId] })
+    queryClient.invalidateQueries({ queryKey: ['historyData', taskId] })
   }
 }
 </script>
diff --git a/src/components/task-management/CategoryAdd.vue b/src/components/task-management/CategoryAdd.vue
@@ -21,7 +21,7 @@
       placeholder-text="1차 카테고리를 선택해주세요"
       v-if="categoryStep == '2'"
       :disabled="route.params.id !== undefined"
-      :is-invalidate="hasMainCategory" />
+      :is-invalidate="!hasMainCategory" />
     <RequestTaskInput
       v-model="categoryForm.name"
       placeholder-text="카테고리명을 입력해주세요"
@@ -97,7 +97,7 @@ const handleGoBack = () => {
 const handleSubmit = async () => {
   hasMainCategory.value = true
   errorMessage.value = { categoryCode: '', categoryName: '' }
-  if (!categoryForm.value.mainCategoryId) {
+  if (!categoryForm.value.mainCategoryId && categoryStep === '2') {
     hasMainCategory.value = false
     return
   } else if (isCodeInvalidate.value) {
diff --git a/src/components/top-bar/NotificationModal.vue b/src/components/top-bar/NotificationModal.vue
@@ -102,8 +102,7 @@ const loadMoreNotifications = async ($state: InfiniteLoadingState) => {
     } else {
       $state.complete()
     }
-  } catch (error) {
-    console.error('알림을 불러오는 중 오류 발생:', error)
+  } catch {
     $state.error()
   }
 }
diff --git a/src/components/top-bar/TopBar.vue b/src/components/top-bar/TopBar.vue
@@ -81,12 +81,9 @@ const isProfileVisible = ref(false)
 
 const fetchNotificationCount = async () => {
   if (!info.value.role) return
-  try {
-    const data = await getNotifiCount()
-    countNotifi.value = data.count
-  } catch (error) {
-    console.error('알림 개수 불러오기 실패:', error)
-  }
+
+  const data = await getNotifiCount()
+  countNotifi.value = data.count
 }
 
 const toggleNotifi = async () => {
diff --git a/src/components/user-manage/DepartmentDropDown.vue b/src/components/user-manage/DepartmentDropDown.vue
@@ -54,10 +54,6 @@ const selectOption = (option: DepartmentType) => {
 }
 
 onMounted(async () => {
-  try {
-    dePartments.value = await getDepartmentsAdmin()
-  } catch (error) {
-    console.error('부서가져오기 실패:', error)
-  }
+  dePartments.value = await getDepartmentsAdmin()
 })
 </script>
diff --git a/src/components/user-manage/UserRegistration.vue b/src/components/user-manage/UserRegistration.vue
@@ -34,7 +34,6 @@
       v-model="userRegistrationForm.role"
       :options="RoleKeys"
       :label-name="'역할'"
-      :is-invalidate="isInvalidate"
       :placeholderText="'회원의 역할을 선택해주세요'" />
     <FormCheckbox
       v-if="isManager"
diff --git a/src/components/user-manage/UserUpdate.vue b/src/components/user-manage/UserUpdate.vue
@@ -36,7 +36,6 @@
       v-model="userRegistrationForm.role"
       :options="RoleKeys"
       :label-name="'역할'"
-      :is-invalidate="isInvalidate"
       :placeholderText="'회원의 역할을 선택해주세요'" />
     <FormCheckbox
       v-if="isManager"
diff --git a/src/stores/member.ts b/src/stores/member.ts
@@ -28,14 +28,10 @@ export const useMemberStore = defineStore('memberInfo', () => {
     const token = Cookies.get('accessToken')
     if (!token) return
 
-    try {
-      const { data }: { data: User } = await axiosInstance.get('/api/members/info')
-      info.value = data
-      isLogined.value = true
-      return data.role
-    } catch (e) {
-      console.log(e)
-    }
+    const { data }: { data: User } = await axiosInstance.get('/api/members/info')
+    info.value = data
+    isLogined.value = true
+    return data.role
   }
 
   function logout() {

Original file line number	Diff line number	Diff line change
`@@ -165,11 +165,7 @@ const handleSubmit = async () => {`
`165`	`165`	`: null,`
`166`	`166`	`labelId: approveData.value.label?.labelId \|\| null`
`167`	`167`	`}`
`168`		`- try {`
`169`		`- await postTaskApprove(requestId, requestData)`
`170`		`- isModalVisible.value = true`
`171`		`- } catch (error) {`
`172`		`- console.error('API 요청 실패:', error)`
`173`		`- }`
	`168`	`+ await postTaskApprove(requestId, requestData)`
	`169`	`+ isModalVisible.value = true`
`174`	`170`	`}`
`175`	`171`	`</script>`
Original file line number	Diff line number	Diff line change
`@@ -127,6 +127,9 @@ const handleSubmit = async () => {`
`127`	`127`	`isInvalidate.value = 'description'`
`128`	`128`	`return`
`129`	`129`	`}`
	`130`	`+`
	`131`	`+ isSubmitting.value = true`
	`132`	`+`
`130`	`133`	`const formData = new FormData()`
`131`	`134`
`132`	`135`	`const attachmentsToDelete = initFileArr.value`
`@@ -168,9 +171,6 @@ const handleSubmit = async () => {`
`168`	`171`	`await patchTaskRequest(id, formData)`
`169`	`172`	`}`
`170`	`173`	`isModalVisible.value = 'success'`
`171`		`- } catch (e) {`
`172`		`- isModalVisible.value = 'fail'`
`173`		`- console.error('요청 실패:', e)`
`174`	`174`	`} finally {`
`175`	`175`	`isSubmitting.value = false`
`176`	`176`	`}`