CLAP-441 Refactor: enum 값 비교 시, equals가 아닌 == 연산자를 사용하도록 수정

#578

Author: joowojr

src/main/java/clap/server/adapter/inbound/security/service/SecurityUserDetails.java

@@ -52,7 +52,7 @@ public static UserDetails from(MemberEntity member) {
                 .userId(member.getMemberId())
                 .username(member.getName())
                 .authorities(List.of(new CustomGrantedAuthority(member.getRole().name())))
-                .accountNonLocked(member.getStatus().equals(MemberStatus.ACTIVE))
+                .accountNonLocked(member.getStatus()==MemberStatus.ACTIVE)
                 .build();
     }
 

src/main/java/clap/server/application/service/admin/DeleteMemberService.java

@@ -26,7 +26,7 @@ public void deleteMember(Long memberId) {
         Member member = loadMemberPort.findById(memberId)
                 .orElseThrow(() -> new ApplicationException(MemberErrorCode.MEMBER_NOT_FOUND));
 
-        if(member.getMemberInfo().getRole().equals(MemberRole.ROLE_MANAGER)){
+        if (member.getMemberInfo().getRole() == MemberRole.ROLE_MANAGER) {
             managerInfoUpdatePolicy.validateNoRemainingTasks(member);
         }
         Hibernate.initialize(member.getDepartment());

src/main/java/clap/server/application/service/admin/ManageMemberService.java

@@ -32,10 +32,8 @@ public void updateMemberInfo(Long adminId, Long memberId, UpdateMemberRequest re
         Member member = memberService.findById(memberId);
         Department department = loadDepartmentPort.findById(request.departmentId()).orElseThrow(() ->
                 new ApplicationException(DepartmentErrorCode.DEPARTMENT_NOT_FOUND));
-
         managerInfoUpdatePolicy.validateDepartment(department, request.role());
-        if(member.getMemberInfo().getRole().equals(MemberRole.ROLE_MANAGER) &&
-                !request.role().equals(MemberRole.ROLE_MANAGER)){
+        if(member.getMemberInfo().getRole() == MemberRole.ROLE_MANAGER && !(request.role()==MemberRole.ROLE_MANAGER)){
             managerInfoUpdatePolicy.validateNoRemainingTasks(member);
         }
 

src/main/java/clap/server/application/service/auth/AuthService.java

@@ -38,7 +38,7 @@ public LoginResponse login(String nickname, String password, String clientIp) {
         Member member = getMember(nickname,clientIp);
         validatePassword(password, member.getPassword(), nickname, clientIp);
 
-        if (member.getStatus().equals(MemberStatus.APPROVAL_REQUEST)) {
+        if (member.getStatus()==MemberStatus.APPROVAL_REQUEST) {
             String temporaryToken = manageTokenService.issueTemporaryToken(member.getMemberId());
             return AuthResponseMapper.toLoginResponse(temporaryToken, null);
         }

src/main/java/clap/server/domain/policy/member/ManagerInfoUpdatePolicy.java

@@ -23,7 +23,7 @@ public void validateDepartment(final Department department, final MemberRole mem
     // 담당자의 잔여 작업이 남아있는 경우 해당 회원의 데이터 수정이 허용되지 않음
     public void validateNoRemainingTasks(final Member member){
         // 최종 회원 등록 전의 경우는 검증하지 않는다.
-        if(member.getStatus().equals(MemberStatus.PENDING) || member.getStatus().equals(MemberStatus.APPROVAL_REQUEST)){
+        if(member.getStatus()==MemberStatus.PENDING || member.getStatus()==MemberStatus.APPROVAL_REQUEST){
             return;
         }
         if(member.getInReviewingTaskCount()>0 || member.getInProgressTaskCount()> 0){