Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Depreciation warning for 2026.1 #845

Closed
ChristophCaina opened this issue Jan 8, 2025 · 4 comments
Closed

Depreciation warning for 2026.1 #845

ChristophCaina opened this issue Jan 8, 2025 · 4 comments
Assignees
Labels
bug Something isn't working question Further information is requested

Comments

@ChristophCaina
Copy link
Contributor

Describe the bug
the following is depricated and will be removed in 2026.1

STATE_DOCKED was used from dreame_vacuum, this is a deprecated constant which will be removed in HA Core 2026.1.
Use VacuumActivity.DOCKED instead, please report it to the author of the 'dreame_vacuum' custom integration
STATE_ERROR was used from dreame_vacuum, this is a deprecated constant which will be removed in HA Core 2026.1.
Use VacuumActivity.ERROR instead, please report it to the author of the 'dreame_vacuum' custom integration
STATE_IDLE was used from dreame_vacuum, this is a deprecated constant which will be removed in HA Core 2026.1.
Use VacuumActivity.IDLE instead, please report it to the author of the 'dreame_vacuum' custom integration
STATE_PAUSED was used from dreame_vacuum, this is a deprecated constant which will be removed in HA Core 2026.1.
Use VacuumActivity.PAUSED instead, please report it to the author of the 'dreame_vacuum' custom integration
STATE_RETURNING was used from dreame_vacuum, this is a deprecated constant which will be removed in HA Core 2026.1.
Use VacuumActivity.RETURNING instead, please report it to the author of the 'dreame_vacuum' custom integration

To Reproduce
Deprication came with 2025.1

Expected behavior

Screenshots

Additional Information (please complete the following information)

  • Model Name [e.g. dreame.vacuum.p2028]: N/A
  • Firmware Version [e.g. 1156]: N/A
  • Home Assistant Version: N/A
  • Configuration Type [With or without map support]: N/A
  • Errors or warnings shown in the HA logs (if applicable): N/A
@ChristophCaina ChristophCaina added bug Something isn't working question Further information is requested labels Jan 8, 2025
ChristophCaina added a commit to ChristophCaina/dreame-vacuum that referenced this issue Jan 8, 2025
changed vacuum STATE_xyz to VacuumActivity.xyz.
This will fix the deprication warning for 2026.1 introduced with HA 2025.1
softplus added a commit to softplus/dreame-vacuum that referenced this issue Feb 2, 2025
@Gatses
Copy link

Gatses commented Feb 18, 2025

Hello!

There are more warnings like this:
Detected that custom integration 'dreame_vacuum' is setting state directly. Entity None (<class 'custom_components.dreame_vacuum.vacuum.DreameVacuum'>) should implement the 'activity' property and return its state using the VacuumActivity enum at custom_components/dreame_vacuum/vacuum.py, line 718: self._attr_state = STATE_CODE_TO_STATE.get(self.device.status.state, STATE_UNKNOWN). This will stop working in Home Assistant 2026.1

Detected that custom integration 'dreame_vacuum' is setting state directly. Entity None (<class 'custom_components.dreame_vacuum.vacuum.DreameVacuum'>) should implement the 'activity' property and return its state using the VacuumActivity enum at custom_components/dreame_vacuum/vacuum.py, line 637: async_add_entities([DreameVacuum(coordinator)]). This will stop working in Home Assistant 2026.1

@Tasshack Tasshack changed the title Deprication warning for 2026.1 Depreciation warning for 2026.1 Feb 20, 2025
@Chaoscontrol
Copy link

Here's another one:

Logger: homeassistant.helpers.frame
Source: helpers/frame.py:324
First occurred: 13:19:22 (1 occurrences)
Last logged: 13:19:22

Detected that custom integration 'dreame_vacuum' sets option flow config_entry explicitly, which is deprecated at custom_components/dreame_vacuum/config_flow.py, line 247: self.config_entry = config_entry. This will stop working in Home Assistant 2025.12, please create a bug report at https://github.com/Tasshack/dreame-vacuum/issues

@NetRat88
Copy link

@Tasshack Thanks for your great work! I really hope the integration will continue, one of the most used by my wife on the wall tablet! Please never stop! :-)

@Tasshack Tasshack closed this as completed Mar 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working question Further information is requested
Projects
None yet
Development

No branches or pull requests

5 participants