From 01891136f9529e1aa53a2e09e06184b47ab011b6 Mon Sep 17 00:00:00 2001 From: Taylor Beebe Date: Mon, 1 May 2023 12:44:16 -0700 Subject: [PATCH] Remove MsWheaEarlyUnitTestApp from Q35 and SBSA Description Remove the failure exemption and test from the Q35 and SBSA platform DSC files. The test is removed from Q35 because the CMOS emulated size is too small to store WHEA records and from SBSA because no early store option currently exists on ARM platforms. - [ ] Impacts functionality? - **Functionality** - Does the change ultimately impact how firmware functions? - Examples: Add a new library, publish a new PPI, update an algorithm, ... - [ ] Impacts security? - **Security** - Does the change have a direct security impact on an application, flow, or firmware? - Examples: Crypto algorithm change, buffer overflow fix, parameter validation improvement, ... - [ ] Breaking change? - **Breaking change** - Will anyone consuming this change experience a break in build or boot behavior? - Examples: Add a new library class, move a module to a different repo, call a function in a new library class in a pre-existing module, ... - [ ] Includes tests? - **Tests** - Does the change include any explicit test code? - Examples: Unit tests, integration tests, robot tests, ... - [ ] Includes documentation? - **Documentation** - Does the change contain explicit documentation additions outside direct code modifications (and comments)? - Examples: Update readme file, add feature readme file, link to documentation on an a separate Web page, ... How This Was Tested N/A Integration Instructions N/A --- Platforms/QemuQ35Pkg/PlatformBuild.py | 1 - Platforms/QemuQ35Pkg/QemuQ35Pkg.dsc | 5 ++++- Platforms/QemuSbsaPkg/PlatformBuild.py | 1 - Platforms/QemuSbsaPkg/QemuSbsaPkg.dsc | 2 +- 4 files changed, 5 insertions(+), 4 deletions(-) diff --git a/Platforms/QemuQ35Pkg/PlatformBuild.py b/Platforms/QemuQ35Pkg/PlatformBuild.py index a6dc5f076..bf6ad526d 100644 --- a/Platforms/QemuQ35Pkg/PlatformBuild.py +++ b/Platforms/QemuQ35Pkg/PlatformBuild.py @@ -30,7 +30,6 @@ FAILURE_EXEMPT_TESTS = { "BootAuditTestApp.efi": datetime.datetime(2023, 3, 7, 0, 0, 0), "LineParserTestApp.efi": datetime.datetime(2023, 3, 7, 0, 0, 0), - "MsWheaEarlyUnitTestApp.efi": datetime.datetime(2023, 3, 7, 0, 0, 0), "VariablePolicyFuncTestApp.efi": datetime.datetime(2023, 3, 7, 0, 0, 0), "DeviceIdTestApp.efi": datetime.datetime(2023, 3, 7, 0, 0, 0), "DxePagingAuditTestApp.efi": datetime.datetime(2023, 3, 7, 0, 0, 0), diff --git a/Platforms/QemuQ35Pkg/QemuQ35Pkg.dsc b/Platforms/QemuQ35Pkg/QemuQ35Pkg.dsc index 215583142..ff12a7da4 100644 --- a/Platforms/QemuQ35Pkg/QemuQ35Pkg.dsc +++ b/Platforms/QemuQ35Pkg/QemuQ35Pkg.dsc @@ -792,6 +792,9 @@ gUefiQemuQ35PkgTokenSpaceGuid.PcdOvmfFlashVariablesEnable|TRUE gQemuPkgTokenSpaceGuid.PcdOvmfHostBridgePciDevId|0x29C0 + # CMOS region is 128 bytes + gMsWheaPkgTokenSpaceGuid.PcdMsWheaReportEarlyStorageCapacity|0x80 + [PcdsFixedAtBuild.IA32] # # The NumberOfPages values below are ad-hoc. They are updated sporadically at @@ -1348,7 +1351,7 @@ MsCorePkg/UnitTests/MathLibUnitTest/MathLibUnitTestApp.inf # MsGraphicsPkg/UnitTests/SpinnerTest/SpinnerTest.inf # DOESN'T PRODUCE OUTPUT MsWheaPkg/Test/UnitTests/Library/LibraryClass/CheckHwErrRecHeaderTestApp.inf - MsWheaPkg/Test/UnitTests/MsWheaEarlyStorageUnitTestApp/MsWheaEarlyUnitTestApp.inf + # MsWheaPkg/Test/UnitTests/MsWheaEarlyStorageUnitTestApp/MsWheaEarlyUnitTestApp.inf # CMOS REGION TOO SMALL TO STORE DATA MsWheaPkg/Test/UnitTests/MsWheaReportUnitTestApp/MsWheaReportUnitTestApp.inf MmSupervisorPkg/Test/MmPagingAuditTest/UEFI/MmPagingAuditApp.inf MmSupervisorPkg/Test/MmSupvRequestUnitTestApp/MmSupvRequestUnitTestApp.inf diff --git a/Platforms/QemuSbsaPkg/PlatformBuild.py b/Platforms/QemuSbsaPkg/PlatformBuild.py index e515be577..74a2c93bb 100644 --- a/Platforms/QemuSbsaPkg/PlatformBuild.py +++ b/Platforms/QemuSbsaPkg/PlatformBuild.py @@ -31,7 +31,6 @@ FAILURE_EXEMPT_TESTS = { "BootAuditTestApp.efi": datetime.datetime(2023, 3, 7, 0, 0, 0), "LineParserTestApp.efi": datetime.datetime(2023, 3, 7, 0, 0, 0), - "MsWheaEarlyUnitTestApp.efi": datetime.datetime(2023, 3, 7, 0, 0, 0), "VariablePolicyFuncTestApp.efi": datetime.datetime(2023, 3, 7, 0, 0, 0), "DeviceIdTestApp.efi": datetime.datetime(2023, 3, 7, 0, 0, 0), "DxePagingAuditTestApp.efi": datetime.datetime(2023, 3, 7, 0, 0, 0), diff --git a/Platforms/QemuSbsaPkg/QemuSbsaPkg.dsc b/Platforms/QemuSbsaPkg/QemuSbsaPkg.dsc index f08034851..7f158e150 100644 --- a/Platforms/QemuSbsaPkg/QemuSbsaPkg.dsc +++ b/Platforms/QemuSbsaPkg/QemuSbsaPkg.dsc @@ -1197,7 +1197,7 @@ MsCorePkg/UnitTests/MathLibUnitTest/MathLibUnitTestApp.inf # MsGraphicsPkg/UnitTests/SpinnerTest/SpinnerTest.inf # DOESN'T PRODUCE OUTPUT MsWheaPkg/Test/UnitTests/Library/LibraryClass/CheckHwErrRecHeaderTestApp.inf - MsWheaPkg/Test/UnitTests/MsWheaEarlyStorageUnitTestApp/MsWheaEarlyUnitTestApp.inf + # MsWheaPkg/Test/UnitTests/MsWheaEarlyStorageUnitTestApp/MsWheaEarlyUnitTestApp.inf # NO EARLY STORE METHOD AVAILABLE ON ARM MsWheaPkg/Test/UnitTests/MsWheaReportUnitTestApp/MsWheaReportUnitTestApp.inf # MmSupervisorPkg/Test/MmPagingAuditTest/UEFI/MmPagingAuditApp.inf # NOT APPLICABLE TO SBSA # MmSupervisorPkg/Test/MmSupvRequestUnitTestApp/MmSupvRequestUnitTestApp.inf # NOT APPLICABLE TO SBSA