Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: replaced poetry with uv #182

Merged
merged 2 commits into from
Aug 24, 2024
Merged

feat: replaced poetry with uv #182

merged 2 commits into from
Aug 24, 2024

Conversation

TeKrop
Copy link
Owner

@TeKrop TeKrop commented Aug 24, 2024 •
edited by sourcery-ai bot
Loading

Summary by Sourcery

Replace 'poetry' with 'uv' for managing Python environments and dependencies across the project, including updates to the CI workflow, Makefile, and application configuration.

New Features:

  • Introduce the use of 'uv' for managing Python environments and dependencies, replacing 'poetry'.

Enhancements:

  • Update the Makefile to use 'uv' for running commands such as starting the application, running linters, formatters, and tests.
  • Modify the application configuration to retrieve the project version from the 'project' section instead of 'tool.poetry'.

CI:

  • Revise the GitHub Actions workflow to set up and use 'uv' for Python environment management and project installation.

@TeKrop TeKrop added the enhancement New feature or request label Aug 24, 2024
@TeKrop TeKrop self-assigned this Aug 24, 2024
@sourcery-ai Sourcery AI
Copy link
Contributor

sourcery-ai bot commented Aug 24, 2024 •
edited
Loading

Reviewer's Guide by Sourcery

This pull request replaces Poetry with uv as the package manager and build tool for the project. The changes primarily affect the build process, development workflow, and how dependencies are managed and executed.

File-Level Changes

Change Details Files
Replace Poetry with uv in GitHub Actions workflow
  • Remove Poetry version from matrix strategy
  • Add uv version to matrix strategy
  • Replace Poetry installation step with uv installation
  • Use uv to set up Python environment
  • Replace Poetry's dependency installation with uv sync
  • Update Ruff and pytest execution to use uv run
 .github/workflows/build.yml
Update Makefile to use uv instead of Poetry
  • Replace direct command execution with uv run for FastAPI, Ruff, and pytest
  • Update lock file generation command to use uv lock
 Makefile
Update project version retrieval in app configuration
  • Change version retrieval path from tool.poetry.version to project.version in pyproject.toml
 app/config.py
Update Docker configuration to use virtual environment
  • Modify FastAPI command to use the virtual environment path
 docker-compose.yml
Tips
  • Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
  • Continue your discussion with Sourcery by replying directly to review comments.
  • You can change your review settings at any time by accessing your dashboard:
    • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
    • Change the review language;
  • You can always contact us if you have any questions or feedback.

sourcery-ai[bot]
sourcery-ai bot reviewed Aug 24, 2024
View reviewed changes
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @TeKrop - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good
Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Aug 24, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@TeKrop TeKrop merged commit 842a684 into main Aug 24, 2024
3 checks passed
@TeKrop TeKrop deleted the feature/uv branch August 24, 2024 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sourcery-ai sourcery-ai[bot] sourcery-ai[bot] left review comments

Assignees

@TeKrop TeKrop

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@TeKrop