Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unreasonable 'File with the same name already exists' prompt appears when renaming a folder without changes #4340

Open
SoapOperaTester opened this issue Jan 6, 2025 · 1 comment · May be fixed by #4347
Open

Unreasonable 'File with the same name already exists' prompt appears when renaming a folder without changes #4340

SoapOperaTester opened this issue Jan 6, 2025 · 1 comment · May be fixed by #4347
Labels
Area-FileOperations Related to file operations (e.g. moving, copying, renaming). Issue-Easy (good first issue) Beginners welcome! Issues with relative low difficulty. Issue-Glitch Graphical issue Issue-Task (low) This isn't a bug, but should be dealt with.

Comments

@SoapOperaTester
Copy link

Describe the bug
The prompt 'File with the same name already exists' appears when attempting to rename a folder without making any changes.

To Reproduce
Steps to reproduce the behavior:

  1. Click on 'Three-dot‘ icon to edit a folder
  2. Click on the 'Rename' button
  3. Click on the 'SAVE' button without modifying the folder name

Expected behavior
Recognize that no changes were made and avoid displaying the 'File with the same name already exists' prompt,
or
Disable the 'SAVE' button if the name remains unchanged.

Screen Recording

Screen.Recording.mov

Smartphone (please complete the following information):

  • Device: [Google Pixel 5]
  • OS: [Android 14]
  • Rooted: [No]
  • Version: [3.10]
@VishnuSanal VishnuSanal added Issue-Task (low) This isn't a bug, but should be dealt with. Issue-Easy (good first issue) Beginners welcome! Issues with relative low difficulty. Area-FileOperations Related to file operations (e.g. moving, copying, renaming). Issue-Glitch Graphical issue labels Jan 12, 2025
@yashwanthgajji yashwanthgajji linked a pull request Jan 23, 2025 that will close this issue
Open
4 tasks
@EmmanuelMess
Copy link
Member

Solution to this is adding a check on the popup similar to file creation ones:

Image

And making the button disabled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-FileOperations Related to file operations (e.g. moving, copying, renaming). Issue-Easy (good first issue) Beginners welcome! Issues with relative low difficulty. Issue-Glitch Graphical issue Issue-Task (low) This isn't a bug, but should be dealt with.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

notify the user when renaming to the same name yashwanthgajji/AmazeFileManager
3 participants
@EmmanuelMess @VishnuSanal @SoapOperaTester