From 8aa22bbe129027f0517683a6af45e362602617d4 Mon Sep 17 00:00:00 2001 From: NuanRMxi <2308425927@qq.com> Date: Thu, 26 Mar 2026 19:08:30 +0800 Subject: [PATCH 1/2] fix: Fake notes should not have fade out effects --- prpr/src/core/note.rs | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/prpr/src/core/note.rs b/prpr/src/core/note.rs index 53c9cb34..5165aa3c 100644 --- a/prpr/src/core/note.rs +++ b/prpr/src/core/note.rs @@ -234,7 +234,7 @@ impl Note { }; if !config.draw_below - && ((res.time - FADEOUT_TIME >= self.time && !matches!(self.kind, NoteKind::Hold { .. })) + && (((res.time - FADEOUT_TIME >= self.time || (self.fake && res.time >= self.time)) && !matches!(self.kind, NoteKind::Hold { .. })) || (self.time > res.time && cover_base <= -0.001)) { return; @@ -255,7 +255,8 @@ impl Note { let draw = |res: &mut Resource, tex: Texture2D| { let mut color = color; if !config.draw_below { - color.a *= (self.time - res.time).min(0.) / FADEOUT_TIME + 1.; + let alpha = (self.time - res.time).min(0.) / FADEOUT_TIME + 1.; + color.a *= if self.fake && res.time >= self.time { 0. } else { alpha }; } color.a *= mod_alpha; res.with_model(self.now_transform(res, ctrl_obj, base, config.incline_sin), |res| { From b6b4a20e3c327bfb5b28fea8835c680f264bad2e Mon Sep 17 00:00:00 2001 From: Mivik <54128043+Mivik@users.noreply.github.com> Date: Fri, 27 Mar 2026 14:25:26 +0800 Subject: [PATCH 2/2] Update prpr/src/core/note.rs --- prpr/src/core/note.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/prpr/src/core/note.rs b/prpr/src/core/note.rs index 5165aa3c..7f467ca6 100644 --- a/prpr/src/core/note.rs +++ b/prpr/src/core/note.rs @@ -234,7 +234,7 @@ impl Note { }; if !config.draw_below - && (((res.time - FADEOUT_TIME >= self.time || (self.fake && res.time >= self.time)) && !matches!(self.kind, NoteKind::Hold { .. })) + && (((res.time - FADEOUT_TIME >= self.time || self.fake && res.time >= self.time) && !matches!(self.kind, NoteKind::Hold { .. })) || (self.time > res.time && cover_base <= -0.001)) { return;