Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fragment is removed from pagination links #38

Open
kmike opened this issue Apr 19, 2016 · 0 comments
Open

fragment is removed from pagination links #38

kmike opened this issue Apr 19, 2016 · 0 comments

Comments

@kmike
Copy link
Contributor

kmike commented Apr 19, 2016

Here:

def _pagination_urls(self, response):
canonicalize_url is called; by default it removes fragment. I think we should check what does fragment usually mean in pagination URLs and decide whether to keep it or drop. If that's too much to check that I think we should keep the fragment by default.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant