Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle long file paths, expecially for deeply embeded MSG files. #202

Open
TheElementalOfDestruction opened this issue Aug 6, 2021 · 1 comment
Assignees
Labels
Accepted This feature request has been accepted and will be developed enhancement In Progress This issue or feature request has been confirmed or approved, respectively, and is being worked on.

Comments

@TheElementalOfDestruction
Copy link
Collaborator

Problem:

Currently the save function has no detection, whatsoever, for long file paths. It is currently possible for a file to end up with a name that is longer than the max path length on Windows (unsure if Unix based systems have a path length maximum, will look into). If is also possible for embedded MSG files, especially ones that are embedded multiple times over, to end up with path lengths that are too long.

Solution:

One solution (which has already been implemented into the next version) is to use a zip file to save the data. It at the very least much less limited in terms of path length than the Windows filesystem. However, the most optimal solution would likely be code that will handle the lengths to ensure that no problems occur. If it is not possible, it should throw an exception. I believe that the save function should also have an argument for manually setting the maximum size, as this will allow people to manually override the length.

@TheElementalOfDestruction TheElementalOfDestruction added Accepted This feature request has been accepted and will be developed enhancement In Progress This issue or feature request has been confirmed or approved, respectively, and is being worked on. labels Aug 7, 2021
@TheElementalOfDestruction
Copy link
Collaborator Author

Partial progress was made to this in version 0.29.0. We want to revisit this again and make it better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Accepted This feature request has been accepted and will be developed enhancement In Progress This issue or feature request has been confirmed or approved, respectively, and is being worked on.
Projects
None yet
Development

No branches or pull requests

1 participant