Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to separate the app's volume control from Android main volume #10556

Open
6 tasks done
benzen3 opened this issue Nov 9, 2023 · 1 comment
Open
6 tasks done
Labels
feature request Issue is related to a feature in the app niche Only relevant to a very small amount of people player Issues related to any player (main, popup and background)

Comments

@benzen3
Copy link

benzen3 commented Nov 9, 2023

Checklist

  • I made sure that there are no existing issues - open or closed - which I could contribute my information to.
  • I have read the FAQ and my problem isn't listed.
  • I'm aware that this is a request for NewPipe itself and that requests for adding a new service need to be made at NewPipeExtractor.
  • I have taken the time to fill in all the required details. I understand that the feature request will be dismissed otherwise.
  • This issue contains only one feature request.
  • I have read and understood the contribution guidelines.

Feature description

Also described in this Stack Exchange post.

An option in the Settings so that the volume of Newpipe's output is decoupled from the Android main volume.

MXPlayer has something very similar in Settings > Audio > Disable the system volume. But this needs the file to be locally downloaded, seems to work with video files only,

Why do you want this feature?

My usecase is listening to some beats from YT, while watching lecture videos on the Youtube app or cloned NewPipe app.

I'm using an older Redmi device, which is running MIUI 12.5 but does not come with Sound Assistant, and is not rooted (rooting is not an option). I've used Shizuku + App Ops to turn off Audio Focus for the needed apps, so now I can play a mixtape on NewPipe and the lecture video on the Youtube app. But I cannot adjust the volumes for the two separately, so the music drowns out the instructor's voice in the lecture.

The only solution it seems is a YT frontend which has its own volume control i.e. the volume control in the app controls the volume of the output it sends to the main audio channel, rather than controlling the device volume.

Additional information

My current solution is using SoundAura from F-droid for the background music — it has its own internal volume control as needed; but it requires me to download the mixtape from YT into local as an mp3 (which I do with NewPipe), and I can't skip forward or backward on playback. SoundAura is open source on Github and written entirely in Kotlin, so I'm hoping importing this feature into NewPipe from their codebase wont be too much of hassle.

@benzen3 benzen3 added feature request Issue is related to a feature in the app needs triage Issue is not yet ready for PR authors to take up labels Nov 9, 2023
@SameenAhnaf SameenAhnaf added player Issues related to any player (main, popup and background) niche Only relevant to a very small amount of people and removed needs triage Issue is not yet ready for PR authors to take up labels Nov 9, 2023
@AudricV
Copy link
Member

AudricV commented Nov 9, 2023

I'm hoping importing this feature into NewPipe from their codebase wont be too much of hassle

No need to do so (this wouldn't be possible anyway, as this app uses directly Android media APIs while we use the ExoPlayer ones), ExoPlayer has an API to implement this feature, see Player.setVolume.

We already use it in the app for the in-app mute commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Issue is related to a feature in the app niche Only relevant to a very small amount of people player Issues related to any player (main, popup and background)
Projects
None yet
Development

No branches or pull requests

3 participants