Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate with SmartTube #10791

Open
6 tasks done
timkgh opened this issue Jan 27, 2024 · 27 comments
Open
6 tasks done

Integrate with SmartTube #10791

timkgh opened this issue Jan 27, 2024 · 27 comments
Labels
feature request Issue is related to a feature in the app niche Only relevant to a very small amount of people

Comments

@timkgh
Copy link

timkgh commented Jan 27, 2024

Checklist

  • I made sure that there are no existing issues - open or closed - which I could contribute my information to.
  • I have read the FAQ and my problem isn't listed.
  • I'm aware that this is a request for NewPipe itself and that requests for adding a new service need to be made at NewPipeExtractor.
  • I have taken the time to fill in all the required details. I understand that the feature request will be dismissed otherwise.
  • This issue contains only one feature request.
  • I have read and understood the contribution guidelines.

Feature description

Integrate with SmartTube. Send video from phone NewPipe app to SmartTube running on Android TV.
SmartTube can already pair with the official YouTube app, maybe it could also pair with NewPipe.

Why do you want this feature?

Make it easy to flick video from phone to TV

Additional information

https://github.com/yuliskov/SmartTube?tab=readme-ov-file#casting

@timkgh timkgh added feature request Issue is related to a feature in the app needs triage Issue is not yet ready for PR authors to take up labels Jan 27, 2024
@opusforlife2
Copy link
Collaborator

Have you tried using KDE Connect or a similar app?

@opusforlife2 opusforlife2 added the waiting for author If the author doesn't respond, the issue will be auto-closed. Otherwise the label will be removed. label Jan 28, 2024
@timkgh
Copy link
Author

timkgh commented Jan 28, 2024

Have you tried using KDE Connect or a similar app?

Not sure I understand how KDE Connect helps pair SmartTube running on Android TV with NewPipe running on my phone. SmartTube can pair with the stock YouTube app on the phone. I'm proposing there should be a way to pair SmartTube with NewPipe also so that one can cast from NP to ST, I'm not looking for alternate solutions to send URLs between devices.

@github-actions github-actions bot removed the waiting for author If the author doesn't respond, the issue will be auto-closed. Otherwise the label will be removed. label Jan 28, 2024
@opusforlife2
Copy link
Collaborator

Make it easy to flick video from phone to TV

This is what you asked for. I gave a solution for it. Try it and see.

@opusforlife2 opusforlife2 added the waiting for author If the author doesn't respond, the issue will be auto-closed. Otherwise the label will be removed. label Jan 28, 2024
@timkgh
Copy link
Author

timkgh commented Jan 28, 2024

I think there are also other ways to do it, using something like BubbleUPnP or PlainUPnP, Yatse/Kore, etc.

I'm looking for a direct integration without adding more apps (and issues).

@github-actions github-actions bot removed the waiting for author If the author doesn't respond, the issue will be auto-closed. Otherwise the label will be removed. label Jan 28, 2024
@opusforlife2
Copy link
Collaborator

Yes, but you could be a dear and help test this for all the other people who might want something similar and would be happy with a compromise solution.

@opusforlife2 opusforlife2 added the waiting for author If the author doesn't respond, the issue will be auto-closed. Otherwise the label will be removed. label Feb 1, 2024
@kwijybo
Copy link

kwijybo commented Feb 10, 2024

@opusforlife2 This attitude is very unhelpful and the suggestion is not related to the issue. please stop.

@opusforlife2
Copy link
Collaborator

I don't see what's harmful about helping out the community. But your wish, I guess. ¯\_(ツ)_/¯

@opusforlife2 opusforlife2 added niche Only relevant to a very small amount of people and removed waiting for author If the author doesn't respond, the issue will be auto-closed. Otherwise the label will be removed. needs triage Issue is not yet ready for PR authors to take up labels Feb 10, 2024
@iBicha
Copy link

iBicha commented Feb 10, 2024

Hi folks, I'm the author of Playlet, and I've recently been exploring "the space" for making casting easier. To kinda sum up things
On the phone we have as options

  • NewPipe
  • ReVanced (which is essentially the official app?)
  • Official YouTube app

And on TV we have

I was exploring how the DIAL protocol works (Link with Wi-Fi option) and essentially I believe NewPipe does not need to implement a special protocol for it to be able to cast to to all 3 TV apps.

In fact I've been prototyping on to cast from the Official YouTube mobile app (and even from the browser) to Playlet.
I have a working "work-in-progress" prototype in Playlet here iBicha/playlet#276, and I have shared my findings and approach in yuliskov/MediaServiceCore#10 because I think the same implementation can work with SmartTube.

So if both SmartTube and Playlet implement the DIAL spec (SmartTube already has the LoungeAPI aka casting) then all NewPipe need to do is to integrate the LoungeAPI to be able to cast to YouTube. Then all the apps listed would be speaking the same protocol and become compatible.

Edit: I believe the ConnectSDK has a DIAL implementation (and many more things) so I guess it can be used find the TVs in the local network

@kubo6472
Copy link

I'd like a guide on the KDE connect thingy. I played with it, but I'm lost how to actually cast anything to my TV. Am I missing something?

@opusforlife2
Copy link
Collaborator

@kubo6472 Are you able to share the video URL from your device to SmartTube on the TV? Does it do anything? Best case scenario it should automatically open SmartTube if it's configured to handle the shared URL intent.

@kubo6472
Copy link

kubo6472 commented Feb 12, 2024 via email

@opusforlife2
Copy link
Collaborator

KDE Connect can't open SmartTube directly

Ah, that sucks. Does the SmartTube app open if you click a YT video link in another (non-browser) app, though? It's possible that it hasn't registered the intent handling with the OS.

@kubo6472
Copy link

kubo6472 commented Feb 13, 2024

Tried newpipe too, yeah, it does open, however it only works when kde connect as an app, is open.

I have no idea if the intent is registered with the browser or not, but it goes like: KDE -> Firefox -> Newpipe/SmartTube

@opusforlife2
Copy link
Collaborator

Try removing Firefox. Then the intent might pass from KDE to Newpipe directly. And if that's the case, then someone could open a feature request with SmartTube to register its URL intents.

@kubo6472
Copy link

Without Firefox just nothing happens. I tried having only one app installed at a time.

@opusforlife2
Copy link
Collaborator

What's your OS version?

@kubo6472
Copy link

kubo6472 commented Feb 13, 2024 via email

@opusforlife2
Copy link
Collaborator

Have you gone into the OS app settings and manually enabled each URL for SmartTube? Does it even have that option?

@kubo6472
Copy link

kubo6472 commented Feb 13, 2024 via email

@opusforlife2
Copy link
Collaborator

Oh. TV OS doesn't have this setting? https://9to5google.com/2021/04/21/android-12-verified-links/

@kubo6472
Copy link

kubo6472 commented Feb 13, 2024 via email

@opusforlife2
Copy link
Collaborator

Alright. Nothing for it but going the whole way then. Thanks for testing!

@exzombie
Copy link

You can use Open Link With, which is a "browser" whose sole purpose is redirecting URLs to apps. Make it the default browser on the TV, it makes life better.

That said, this won't solve the issue that the kde connect app needs to be open on the TV; I've tried the LocalSend app, and it has the same issue. It's just doesn't seem possible to send an URL to the TV in a generic way that would work while NewPipe is open. Switching apps on the TV is not as easy as on a phone, especially for KDE connect which is not added to the home screen and has to be accessed through settings.

@timkgh
Copy link
Author

timkgh commented Feb 14, 2024

This is a lot more complicated than it really needs to be. Quality of life would be improved if NewPipe just supported the TV linking protocol.

@kubo6472
Copy link

You can use Open Link With, which is a "browser" whose sole purpose is redirecting URLs to apps. Make it the default browser on the TV, it makes life better.

That said, this won't solve the issue that the kde connect app needs to be open on the TV; I've tried the LocalSend app, and it has the same issue. It's just doesn't seem possible to send an URL to the TV in a generic way that would work while NewPipe is open. Switching apps on the TV is not as easy as on a phone, especially for KDE connect which is not added to the home screen and has to be accessed through settings.

I have a question that I might try later: what if I put Firefox mobile on the TV, login with my account, then use the Open Link With, or Firefox directly to launch NewPipe/SmartTube by sending the tab with the YouTube video?

@ilar
Copy link

ilar commented Mar 25, 2024

This is a lot more complicated than it really needs to be. Quality of life would be improved if NewPipe just supported the TV linking protocol.

Yes, can we please drop the side discussions about KDE Connect and other kludges? They really have no place here, this isn't a tech support chat.

Also, adding the 'niche' tag is just petty. The sheer number of tickets, reddit posts, and google search results for casting from newpipe clearly says otherwise.

@kubo6472
Copy link

Yes, can we please drop the side discussions about KDE Connect and other kludges?

Me personally... I just wanted to try what a NewPipe Development/Team Member suggests, and if it works at all.

It was janky and not working most of the time.

They really have no place here, this isn't a tech support chat.

I suppose, that even though I joined the matrix channel, I was still getting answers here. People reading this can now safely dismiss this "(non-)workaround" right away.

My 2 cents is that it was for the better leading the "trying of alternatives" discussion right in this chat 😉.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Issue is related to a feature in the app niche Only relevant to a very small amount of people
Projects
None yet
Development

No branches or pull requests

7 participants