Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Remove watched" with "Remove duplicates" without closing and re-opening the playlist does not work correctly #11138

Open
6 tasks done
emanuele6 opened this issue Jun 6, 2024 · 1 comment
Labels
bug Issue is related to a bug database Issue is related to database operations playlist Anything to do with playlists in the app

Comments

@emanuele6
Copy link

Checklist

  • I am able to reproduce the bug with the latest version given here: CLICK THIS LINK.
  • I made sure that there are no existing issues - open or closed - which I could contribute my information to.
  • I have read the FAQ and my problem isn't listed.
  • I have taken the time to fill in all the required details. I understand that the bug report will be dismissed otherwise.
  • This issue contains only one bug.
  • I have read and understood the contribution guidelines.

Affected version

0.27.0

Steps to reproduce the bug

  1. Create a new playlist with two contents, one watched, and one not watched. Also add a duplicate for each content. You should have two copies of the watched content, and two copies of the non-watched content.
  2. Open that playlist
  3. ... -> "Remove watched" -> "OK"; the two copies of the watched content should have been removed, and only the two copies of the non-watched content should remain
  4. Without exiting, ... -> "Remove duplicates" -> "OK"

Expected behavior

What should happen is that one of the two copies of the content that is left in the playlist should be removed, leaving only one copy of the non-watched content in the playlist.

Actual behavior

What actually happens is that the contents that were previously deleted by "Remove watched" are added back, and then, from the original state of the playlist (2x watched + 2x non-watched) duplicates are removed, so you are left with one copy of the watched content, and one copy of the non-watched content.

The Remove watched/Remove duplicates change is only "commited" after you exit the playlist page.
You have to: ... -> "Remove watched" -> "OK" -> -> re-open playlist -> ... -> "Remove duplicates" -> "OK"
to remove both watched and duplicates.

Screenshots/Screen recordings

No response

Logs

No response

Affected Android/Custom ROM version

Android 13 / One UI Core 5.1

Affected device model

Samsung Galaxy A22 5G

Additional information

No response

@emanuele6 emanuele6 added bug Issue is related to a bug needs triage Issue is not yet ready for PR authors to take up labels Jun 6, 2024
@emanuele6 emanuele6 changed the title "Remove watched" with "Removed duplicates" without closing and re-opening the playlist does not work corrently "Remove watched" with "Remove duplicates" without closing and re-opening the playlist does not work corrently Jun 6, 2024
@emanuele6 emanuele6 changed the title "Remove watched" with "Remove duplicates" without closing and re-opening the playlist does not work corrently "Remove watched" with "Remove duplicates" without closing and re-opening the playlist does not work correctly Jun 7, 2024
@opusforlife2
Copy link
Collaborator

So certain actions should be carried out immediately, instead of waiting for the playlist to be closed/reopened before committing to the database.

@opusforlife2 opusforlife2 added database Issue is related to database operations playlist Anything to do with playlists in the app and removed needs triage Issue is not yet ready for PR authors to take up labels Jun 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue is related to a bug database Issue is related to database operations playlist Anything to do with playlists in the app
Projects
None yet
Development

No branches or pull requests

2 participants