Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite Issue 2: The (Complete) Kotlin Migration #11199

Open
opusforlife2 opened this issue Jun 21, 2024 · 4 comments
Open

Rewrite Issue 2: The (Complete) Kotlin Migration #11199

opusforlife2 opened this issue Jun 21, 2024 · 4 comments
Labels
discussion This needs to be discussed before anything is done feature request Issue is related to a feature in the app

Comments

@opusforlife2
Copy link
Collaborator

opusforlife2 commented Jun 21, 2024

Feature description

Newpipe is intended to be migrated completely to Kotlin. It is currently a mix of both Java and Kotlin. This is a meta issue to coordinate efforts and keep everyone informed.

Why do you want this feature?

See #10118.

Additional information

@snaik20 @uragiristereo @imashnake0 @lm41 @YongJunLim @AaronRietschlin @sandy-8925 @PrimoDev23 @EricDriussi @rahul-gill @Profpatsch @Chinaqth @acrodemocide @fuzzblob @XilinJia @GGindin @davidasunmo @chriss2401

Let us know if you're willing and currently able to participate.

If anyone is already a Kotlin expert/veteran here, please let us know about that too. Not everyone on the team is familiar with it.

Also, here's a bit of guidance from @Stypox on this: Guidelines.pdf

@opusforlife2 opusforlife2 added feature request Issue is related to a feature in the app needs triage Issue is not yet ready for PR authors to take up discussion This needs to be discussed before anything is done and removed needs triage Issue is not yet ready for PR authors to take up labels Jun 21, 2024
@EricDriussi
Copy link
Contributor

Hey! I noticed PR #10922 seems to be on this line of work, is there any reason it was never merged?

Also, while setting up the project I noticed a section in the contribution guidelines mentioning PRs involving Kotlin conversion should be avoided.

Is it ok for me to open a PR updating/removing that section to ensure consistency?

@chriss2401
Copy link

Does this include the extractor ? I might take a look at that repo if yes.

@XilinJia
Copy link

I've actually done a full conversion of the NewPipe to Kotlin 2 months ago (though it's not in Compose) and posted an issue regarding merging possibilities. But I guess we only prefer small step conversions? https://github.com/XilinJia/NewPipeX

@opusforlife2
Copy link
Collaborator Author

is there any reason it was never merged?

Lack of dev time (and hence review time) has been mentioned in the rewrite discussion. That still hasn't changed. We're hoping you guys can help review PRs as well.

Is it ok for me to open a PR updating/removing that section to ensure consistency?

Yes, now that the project is committed to going fully Kotlin, it should be removed. The idea back then was that newcomers to the project would have an easier time with Java.

Does this include the extractor ?

No, the rewrite is completely about the Android app. There's been no such decision on doing this for the extractor.

But I guess we only prefer small step conversions?

Same reason. Lack of dev review time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion This needs to be discussed before anything is done feature request Issue is related to a feature in the app
Projects
None yet
Development

No branches or pull requests

4 participants