Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audio only does not save data in live streams using HLS #11756

Open
6 tasks done
cyanescent opened this issue Nov 28, 2024 · 2 comments
Open
6 tasks done

Audio only does not save data in live streams using HLS #11756

cyanescent opened this issue Nov 28, 2024 · 2 comments
Labels
bug Issue is related to a bug multiservice Issues related to multiple services player Issues related to any player (main, popup and background)

Comments

@cyanescent
Copy link

cyanescent commented Nov 28, 2024

Checklist

  • I am able to reproduce the bug with the latest version given here: CLICK THIS LINK.
  • I made sure that there are no existing issues - open or closed - which I could contribute my information to.
  • I have read the FAQ and my problem isn't listed.
  • I have taken the time to fill in all the required details. I understand that the bug report will be dismissed otherwise.
  • This issue contains only one bug.
  • I have read and understood the contribution guidelines.

Affected version

0.27.2

Steps to reproduce the bug

  1. Show network speed indicator in the top bar to measure the download speed.
  2. Open a live stream in NewPipe with audio only: ~200-300 kB/s.
  3. Close NewPipe and switch to the same Youtube live through a browser (Brave).
  4. Choose the minimum resolution (144p): ~40 kB/s.

Expected behavior

The step 2 should show a data usage <40 kB/s and actually save data compared to a video live stream.

Actual behavior

The data usage remains high in NewPipe with audio only, even after 1 min.

Affected Android/Custom ROM version

Android 13 /e/OS 2.5

Affected device model

Fairphone 3+

@cyanescent cyanescent added bug Issue is related to a bug needs triage Issue is not yet ready for PR authors to take up labels Nov 28, 2024
@opusforlife2
Copy link
Collaborator

From #7349, this is the reason:

Note that livestreams will still fetch the video stream (because streams we are getting right now are not demuxed (this will probably change soon) and there is an ExoPlayer bug which still fetches video even if it has been disabled with the track selector for HLS contents (the delivery method we can only use for livestreams right now) (a low priority has been given by the ExoPlayer team to this bug)).

@AudricV Has the situation changed here? Maybe media3 doesn't have this problem?

@opusforlife2 opusforlife2 added question Not really an issue, but more of a question about how something works and removed bug Issue is related to a bug labels Dec 1, 2024
@AudricV
Copy link
Member

AudricV commented Dec 1, 2024

No, nothing has changed sadly in Media3.

DASH manifests can be prioritized as a workaround, but in order to use the DASH manifests of YouTube livestreams (version 5 up to 7), we need to fix them, as ExoPlayer starts them from the beginning of the live window (only the period?) (i.e. the earliest point with which you can rewind). For other services that use HLS for livestreams only, nothing will change.

I don't know right now what causes the start position issue (it doesn't seem to be a NewPipe bug this time). For some reason, the availabilityStartTime property in DASH manifests of YouTube causes issues in ExoPlayer. Setting this value to "1970-01-01T00:00:00Z" like in this sample makes the library handle things like expected.

@opusforlife2 opusforlife2 added feature request Issue is related to a feature in the app youtube Service, https://www.youtube.com/ player Issues related to any player (main, popup and background) and removed question Not really an issue, but more of a question about how something works needs triage Issue is not yet ready for PR authors to take up labels Dec 1, 2024
@AudricV AudricV added multiservice Issues related to multiple services bug Issue is related to a bug and removed youtube Service, https://www.youtube.com/ feature request Issue is related to a feature in the app labels Dec 1, 2024
@AudricV AudricV changed the title Audio only does not save data in live stream. Audio only does not save data in live streams using HLS Dec 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue is related to a bug multiservice Issues related to multiple services player Issues related to any player (main, popup and background)
Projects
None yet
Development

No branches or pull requests

3 participants