Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navigation issues on Android TV #4004

Closed
gkeegan opened this issue Jul 29, 2020 · 6 comments
Closed

Navigation issues on Android TV #4004

gkeegan opened this issue Jul 29, 2020 · 6 comments
Labels
Android TV Issue is related to Android TV bug Issue is related to a bug duplicate Issue or discussion is a duplicate of an existing issue or discussion GUI Issue is related to the graphical user interface

Comments

@gkeegan
Copy link
Contributor

gkeegan commented Jul 29, 2020

Version

  • 0.19.8

Expected behavior

Android TV navigation works well and doesn't require workarounds in order to click certain buttons.

Actual behaviour

Navigating to get to certain buttons (in particular the different feeds on the subscription page and the refresh feed button) is very wonky and requires setting the cursor in certain positions in order to navigate to those buttons.

The video shows these issues quite well.

Screenshots/Screen recordings

https://streamable.com/smm3k5

I'm waiting to peel the stickers off the TV once I get it on the cabinet, don't hurt me lol.

@gkeegan gkeegan added the bug Issue is related to a bug label Jul 29, 2020
@Stypox Stypox added Android TV Issue is related to Android TV GUI Issue is related to the graphical user interface labels Jul 29, 2020
@Stypox
Copy link
Member

Stypox commented Jul 29, 2020

@Alexander-- would you mind taking a look?

@Alexander--
Copy link
Contributor

@Stypox I didn't watch the video (@gkeegan could you upload it to youtube?) but I suspect, that everything works as designed.

The subscription page used to be better when I initially worked on it, but ever since it went through round of beautification in #2309 it have gotten a lot worse. The entire subscription group screen has become a single massive RecyclerView with a GridLayoutManager. With all associated focus handling bugs.

Normally, it is possible to work around most focus issues by manually assigning nextFocusXxx in XML layout files. But in case of action bar icons and RecyclerViews that does not work, because there is no coherent layout file... When I fixed up a comment feed, I wrote a custom LinerLayoutManager, — SuperScrollLayoutManager — that dealt with most of it's issues. Unfortunately, writing something like that for GridLayoutManager proved significantly harder. Possibly multiple days worth of work.

If navigation works at all on that screen, I'd consider that great already.

@gkeegan
Copy link
Contributor Author

gkeegan commented Jul 29, 2020

@Alexander-- yes it does feel like a grid issue, since a lot of the behavior feels like I'm dealing with a grid of different sized boxes.

I think an interim solution would be to make the buttons for feeds the same size as each subscription so it is more obvious how to navigate to it. Or, if it is possible, changing the starting position of the cursor to somewhere different.

And I cannot upload to YouTube sorry. I could use another video host that doesn't require sign in if streamable doesn't work right.

@jstaro
Copy link

jstaro commented Oct 29, 2020

How do you actually refresh the subscription list? I seem completely unable to navigate to that button.

@christopher-wilson
Copy link

@jstaro If you are still having an issue, maybe try navigating to your middle tab, then pressing down.

@opusforlife2
Copy link
Collaborator

Closing in favour of #11197.

@opusforlife2 opusforlife2 added the duplicate Issue or discussion is a duplicate of an existing issue or discussion label Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Android TV Issue is related to Android TV bug Issue is related to a bug duplicate Issue or discussion is a duplicate of an existing issue or discussion GUI Issue is related to the graphical user interface
Projects
None yet
Development

No branches or pull requests

6 participants