Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audio Player #4419

Closed
ghost opened this issue Oct 6, 2020 · 9 comments
Closed

Audio Player #4419

ghost opened this issue Oct 6, 2020 · 9 comments
Labels
bug Issue is related to a bug

Comments

@ghost
Copy link

ghost commented Oct 6, 2020

Tapping on notification, after tapping on "background button" under a video being played, will open the audio player.

Shouldn't this avoided with unified players?

@ghost ghost added the bug Issue is related to a bug label Oct 6, 2020
@ghost
Copy link
Author

ghost commented Oct 6, 2020

@Stypox @avently

@avently
Copy link
Contributor

avently commented Oct 6, 2020

Why do you want it to be avoided?

@ghost
Copy link
Author

ghost commented Oct 6, 2020

Why do you want it to be avoided?

Because:

  1. This player is bugged: if you try to make the closing app gesture, time cursor will move.

  2. It's redundant, there is already (unified) video player.

@avently
Copy link
Contributor

avently commented Oct 6, 2020

@Oizaro

  1. Show a screenrecord
  2. Without this queue you'll not be able to control background (audio) playback and its params (speed, stream position, etc)

@ghost
Copy link
Author

ghost commented Oct 6, 2020

@Oizaro

  1. Show a screenrecord
  2. Without this queue you'll not be able to control background (audio) playback and its params (speed, stream position, etc)
  1. Can't you just move this to notification or video player?

@opusforlife2
Copy link
Collaborator

  1. If the closing app gesture is to swipe up from the bottom, then that's being interpreted as a drag on the seekbar. @avently You already implemented a fix for this in the main player, right?

  2. As in tapping the notification should open the main player?

@avently
Copy link
Contributor

avently commented Oct 6, 2020

@opusforlife2 this guy probably doesn't have an android gesture but custom one without displayed navbar. So no fix for this

@opusforlife2
Copy link
Collaborator

I think I have seen such a thing on Realme phones.

@Stypox
Copy link
Member

Stypox commented Oct 6, 2020

Let's close in favour of #3515

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue is related to a bug
Projects
None yet
Development

No branches or pull requests

3 participants