[refactor] 핑글 카드 커스텀 뷰 분리 및 지도 ViewPager Item 재구현 #185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jihyunniiii
changed the title
HAJIEUN02
approved these changes
Feb 16, 2024
| tvCardTopInfoName.text = pingleEntity.name | ||
| tvCardTopInfoOwnerName.text = pingleEntity.ownerName | ||
|
|
||
| (pingleEntity.isCompleted()).let { isCompleted -> |
There was a problem hiding this comment.
좋네요!! 언니가 코리 달아준 스코프 함수를 이용해서 깔쌈하게 비지블 처리해주기
| android:layout_height="wrap_content" | ||
| android:layout_marginStart="8dp" | ||
| android:src="@drawable/ic_all_calendar_24" | ||
| app:layout_constraintStart_toStartOf="@+id/btn_card_bottom_map_chat" |
There was a problem hiding this comment.
아놔 ㅋㅋ 들켜버렸다,,,
|
|
||
| <TextView | ||
| android:id="@+id/tv_card_top_info_participation_status_title" | ||
| android:layout_width="wrap_content" |
There was a problem hiding this comment.
요거는 4군데에 다 제약을 걸었는데 0dp 사용이 안되나요?!
There was a problem hiding this comment.
wrap_content가 적합한 상황이라 wrap_content 사용했어요
텍스트 길이에 딱 맞는 너비를 가져야 하거든요 (아니면 뷰 깨짐 이슈,, -> 아래 사진 참고해주세요)
jihyunniiii
commented
Feb 16, 2024
| android:layout_height="wrap_content" | ||
| android:layout_marginStart="8dp" | ||
| android:src="@drawable/ic_all_calendar_24" | ||
| app:layout_constraintStart_toStartOf="@+id/btn_card_bottom_map_chat" |
There was a problem hiding this comment.
아놔 ㅋㅋ 들켜버렸다,,,
|
|
||
| <TextView | ||
| android:id="@+id/tv_card_top_info_participation_status_title" | ||
| android:layout_width="wrap_content" |
There was a problem hiding this comment.
wrap_content가 적합한 상황이라 wrap_content 사용했어요
텍스트 길이에 딱 맞는 너비를 가져야 하거든요 (아니면 뷰 깨짐 이슈,, -> 아래 사진 참고해주세요)
Comment on lines
57
to
61
| layoutCardTopParticipationStatus.setOnClickListener { | ||
| Intent(context, ParticipantActivity::class.java).apply { | ||
| putExtra(MEETING_ID, pingleEntity.id) | ||
| context.startActivity(this) | ||
| } |
There was a problem hiding this comment.
[다은] UI 로직 분리 진행
Dan2dani
approved these changes
Feb 20, 2024
| parent, | ||
| false | ||
| ), | ||
| navigateToParticipant = navigateToParticipant, |
DoReMinWoo
approved these changes
Feb 20, 2024
Comment on lines
+58
to
+62
| when { | ||
| pingleEntity.isOwner -> stringOf(R.string.pingle_card_delete) | ||
| pingleEntity.isParticipating -> stringOf(R.string.pingle_card_cancel) | ||
| else -> stringOf(R.string.pingle_card_participate) | ||
| } |
There was a problem hiding this comment.
오옹 이런식으로 when문 사용하는 거 너무 좋네요
jihyunniiii
commented
Feb 20, 2024
Comment on lines
69
to
70
|
|
||
|
|
There was a problem hiding this comment.
[민우] 한 줄로 바꿔주세요 ~
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue 🛠
Work Description ✏️
Screenshot 📸
Screen_recording_20240216_010429.mp4
Uncompleted Tasks 😅
To Reviewers 📢
운영 서버로 카드 분기처리 확인하였습니다 ~