[feat] 랭킹 뷰 구현 #190

jihyunniiii · 2024-02-17T12:03:17Z

Related issue 🛠

closed [feat] 랭킹 뷰 구현 #189

Work Description ✏️

랭킹 뷰를 구현하였습니다.

Screenshot 📸

랭킹 뷰

Screen_recording_20240217_205919.mp4

EmptyView

Uncompleted Tasks 😅

N/A

To Reviewers 📢

더미 넣어서 값 확인했습니다 ~
MyPingleAdapter 에서도 context 안 넘기도록 수정했습니다.

HAJIEUN02

너무 깔끔하게 잘 짜셨다고 생각합니다.

HAJIEUN02 · 2024-02-17T12:37:30Z

app/src/main/java/org/sopt/pingle/presentation/ui/main/ranking/RankingFragment.kt

+    }
+
+    private fun initLayout() {
+        rankingAdapter = RankingAdapter(context = requireContext())


오 언니 약간 코드스타일 바뀜핑
원래 이렇게 매개변수 명시 안 해두지 않았남?
더 보기 조아요!

원래 매개변수 적을 땐 안 했는데 하는 게 더 깔끔한 것 같아서 바꿔봤숨다 ㅋ.ㅋ

HAJIEUN02 · 2024-02-17T12:38:57Z

app/src/main/java/org/sopt/pingle/presentation/ui/main/ranking/RankingViewHolder.kt

+    RecyclerView.ViewHolder(binding.root) {
+    fun onBind(rankingLocationEntity: RankingLocationEntity, ranking: Int) {
+        with(binding) {
+            tvRankingRank.text = (ranking).toString()


여기 ranking에 괄호 없애주는게 좋지 않을까염?

아놔 ㅜ 당장 수정

HAJIEUN02 · 2024-02-17T12:39:52Z

app/src/main/java/org/sopt/pingle/presentation/ui/main/ranking/RankingViewModel.kt

+                locationCount = 17
+            ),
+            RankingLocationEntity(
+                name = "동탄시범다은마을월드메르디앙반도유보라아파트경비실",


이게 대체 뭔데
ㅋ ㅋ
ㅋㅋ
ㅋㅋㅋ ㅋ ㅋ ㅋ

ㄷㄷ 진짜 있네

ㅋㅋㅋㅋㅋㅋㅋㅋㅋㅋㅋㅋㅋㅋㅋㅋㅋㅋㅋㅋㅋㅋㅋㅋㅋㅋ 두 줄 확인 해보려고 네이버에 이름 긴 아파트 검색했숨요 ㅋ.ㅋ

HAJIEUN02 · 2024-02-17T12:41:03Z

app/src/main/res/layout/fragment_ranking.xml

@@ -12,41 +12,57 @@
        android:layout_height="match_parent"
        tools:context=".presentation.ui.main.ranking.RankingFragment">

-        <TextView


언니 이거 비밀인데 나 이제 가이드라인 쓸 줄 안다 ㅋ
혼자 해봤음ㅋ
칭찬해쥬삼

다 컸다 ㅋ.ㅋ 이제 내가 알려줄 게 없구만 ㅋㅋ UMC 레포 좀 알려줘봐요 ㅋㅋ 구경 좀 하게

HAJIEUN02 · 2024-02-17T12:42:02Z

app/src/main/res/layout/fragment_ranking.xml

-            app:layout_constraintEnd_toEndOf="parent"
-            app:layout_constraintStart_toStartOf="parent"
-            app:layout_constraintTop_toBottomOf="@id/tv_ranking_construction_title" />
+            app:layout_constraintStart_toStartOf="@+id/gl_start"


정말 예리핑이시네요

DoReMinWoo

고생핑고생핑~!

DoReMinWoo · 2024-02-20T11:03:24Z

app/src/main/java/org/sopt/pingle/presentation/ui/main/ranking/RankingFragment.kt

+        // TODO 서버통신 구현 후 collectData 함수로 해당 로직 이동
+        with(viewModel.dummyRanking) {
+            (meetingCount >= RANKING_VISIBLE_THRESHOLD).let { isRankingVisible ->
+                if (isRankingVisible) rankingAdapter.submitList(locations)
+                binding.tvRankingEmpty.visibility =
+                    if (isRankingVisible) View.INVISIBLE else View.VISIBLE
+            }
+        }


미리 구현 굿굿

DoReMinWoo · 2024-02-20T11:14:47Z

app/src/main/res/layout/item_ranking.xml

+        android:layout_marginTop="4dp"
+        android:layout_marginBottom="7dp">


피그마에서 리사이클러뷰 맨 밑 간격이 16dp인데 이렇게 margin 주게 되면 16dp안되지않나요!?!
조금있다가 자세히 설명할게여...

jihyunniiii · 2024-02-20T12:32:17Z

app/src/main/java/org/sopt/pingle/presentation/ui/main/ranking/RankingViewHolder.kt

+                tvRankingLocationDate.text = context.getString(
+                    R.string.ranking_date,
+                    latestVisitedDate[YEAR_INDEX],
+                    latestVisitedDate[MONTH_INDEX],
+                    latestVisitedDate[DAY_INDEX]
+                )
+            }


이거 스트링으로 변경하는 과정 UI에서 하지 말기

-> 서버통신 구현하면서 수정 예정

jihyunniiii · 2024-02-20T12:33:32Z

app/src/main/java/org/sopt/pingle/presentation/ui/main/ranking/RankingAdapter.kt

+import org.sopt.pingle.domain.model.RankingLocationEntity
+import org.sopt.pingle.util.view.ItemDiffCallback
+
+class RankingAdapter(private val context: Context) :


여기서 context 안 넘기는 방안에 대해서 고민해보기 (parent.context)

jihyunniiii added 9 commits February 17, 2024 13:35

[add] #189 랭킹 뷰 구현을 위한 이미지 리소스 추가

d614ffc

[add] #189 랭킹 뷰 구현을 위한 string 리소스 추가

f379ae8

[feat] #189 랭킹 뷰 UI 구현

436ee89

[feat] #189 랭킹 뷰 아이템 UI 구현

5cd4007

[add] #189 랭킹 뷰 구현을 위한 스트링 리소스 추가

3fe49b4

[chore] #189 스트링리소스 %s -> %d 변경

8dae619

[feat] #189 랭킹 리사이클러뷰 구현

ecae770

[feat] #189 랭킹 관련 Entity 추가

7b2ec0d

[feat] #189 랭킹 리사이클러뷰 layoutManager

8f9518b

jihyunniiii added ✨ feat ✨ 🐸 지현 🐸 labels Feb 17, 2024

jihyunniiii added this to the 3차 스프린트 뷰 작업 milestone Feb 17, 2024

jihyunniiii self-assigned this Feb 17, 2024

jihyunniiii requested a review from a team as a code owner February 17, 2024 12:03

[chore] #189 ktlintFormat

cc74919

HAJIEUN02 approved these changes Feb 17, 2024

View reviewed changes

jihyunniiii added 2 commits February 17, 2024 22:21

[chore] #189 @+id -> @id

56cde87

[chore] #189 () 제거

e58493f

DoReMinWoo approved these changes Feb 20, 2024

View reviewed changes

jihyunniiii commented Feb 20, 2024

View reviewed changes

jihyunniiii added 7 commits February 22, 2024 00:21

[chore] #189 item_ranking.xml 상하 마진 수정

83a61cf

[chore] #189 RankingAdapter 매개변수 수정 (context 제거)

d5bfb32

[chore] #189 MyPingleAdapter 네이밍 수정

0daabda

[chore] #189 MyPingleAdapter 매개변수 수정 (context 제거)

0efef03

[chore] #189 오타 수정

8231550

[chore] #189 불필요한 () 제거

c990adb

[chore] #189 ktlintFormat

f26494f

jihyunniiii merged commit db866ae into develop Feb 21, 2024
1 check passed

jihyunniiii deleted the feat-ranking-view branch February 21, 2024 15:37

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[feat] 랭킹 뷰 구현 #190

[feat] 랭킹 뷰 구현 #190

jihyunniiii commented Feb 17, 2024 •

edited

Loading

HAJIEUN02 left a comment

HAJIEUN02 Feb 17, 2024

jihyunniiii Feb 17, 2024

HAJIEUN02 Feb 17, 2024

jihyunniiii Feb 17, 2024

HAJIEUN02 Feb 17, 2024

HAJIEUN02 Feb 17, 2024

jihyunniiii Feb 17, 2024

HAJIEUN02 Feb 17, 2024

jihyunniiii Feb 17, 2024

HAJIEUN02 Feb 17, 2024

jihyunniiii Feb 17, 2024

DoReMinWoo left a comment

DoReMinWoo Feb 20, 2024

DoReMinWoo Feb 20, 2024

jihyunniiii Feb 20, 2024

jihyunniiii Feb 21, 2024

jihyunniiii Feb 20, 2024

		android:layout_marginTop="4dp"
		android:layout_marginBottom="7dp">

[feat] 랭킹 뷰 구현 #190

[feat] 랭킹 뷰 구현 #190

Conversation

jihyunniiii commented Feb 17, 2024 • edited Loading

Related issue 🛠

Work Description ✏️

Screenshot 📸

Uncompleted Tasks 😅

To Reviewers 📢

HAJIEUN02 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

DoReMinWoo left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jihyunniiii commented Feb 17, 2024 •

edited

Loading