Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feat] 커스텀 Search Bar 적용 #192

Merged
merged 3 commits into from
Feb 20, 2024
Merged

[feat] 커스텀 Search Bar 적용 #192

merged 3 commits into from
Feb 20, 2024

Conversation

jihyunniiii
Copy link
Collaborator

Related issue 🛠

Work Description ✏️

  • 기존에 Search Bar가 사용되었던 뷰에 커스텀 Search Bar를 적용하였습니다. (기존 단체 입장 - 단체 검색 뷰, 핑글 개최 프로세스 - 장소 선택 뷰)

Screenshot 📸

  • 기존 단체 입장 - 단체 검색 뷰
Screen_recording_20240217_235936.mp4
  • 핑글 개최 프로세스 - 장소 선택 뷰
Screen_recording_20240218_001134.mp4

Uncompleted Tasks 😅

  • N/A

To Reviewers 📢

  • hideKeyboard 함수에 clearFocus 적용해둔 거 아직 머지 안 되어서 여기 영상엔 반영되지 않았습니당!

@jihyunniiii jihyunniiii self-assigned this Feb 17, 2024
@jihyunniiii jihyunniiii requested a review from a team as a code owner February 17, 2024 15:16
HAJIEUN02
HAJIEUN02 approved these changes Feb 20, 2024
View reviewed changes
Copy link
Collaborator

@HAJIEUN02 HAJIEUN02 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

요번 거는 진짜 코리 달 게 없는 것 같아요 LGTMㅋㅋ
고생핑 ~~ 🍕

Dan2dani
Dan2dani approved these changes Feb 20, 2024
View reviewed changes
Copy link
Collaborator

@Dan2dani Dan2dani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jihyunniiii jihyunniiii merged commit d82771a into develop Feb 20, 2024
1 check passed
@jihyunniiii jihyunniiii deleted the feat-search-bar-apply branch February 20, 2024 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DoReMinWoo DoReMinWoo DoReMinWoo approved these changes

@HAJIEUN02 HAJIEUN02 HAJIEUN02 approved these changes

@Dan2dani Dan2dani Dan2dani approved these changes

Assignees

@jihyunniiii jihyunniiii

Labels
✨ feat ✨ 🐸 지현 🐸
Projects
PINGLE-ANDROID
Status: Done
Milestone
1차, 2차 스프린트 리팩토링
Development

Successfully merging this pull request may close these issues.

[feat] 커스텀 Search Bar 적용
4 participants
@jihyunniiii @Dan2dani @HAJIEUN02 @DoReMinWoo