[feat] PingleTag 추가 #198
Merged
[feat] PingleTag 추가 #198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR 이름 수정해주세염 ~ |
jihyunniiii
reviewed
Feb 23, 2024
app/src/main/res/values/themes.xml
Outdated
Comment on lines
111
to
120
| <style name="Theme.Pingle.Tag" parent="Widget.MaterialComponents.Chip.Choice"> | ||
| <item name="android:stateListAnimator">@null</item> | ||
| <item name="chipMinTouchTargetSize">0dp</item> | ||
| <item name="chipEndPadding">0dp</item> | ||
| <item name="chipStartPadding">0dp</item> | ||
| <item name="android:checked">false</item> | ||
| <item name="chipMinHeight">0dp</item> | ||
| <item name="backgroundTint">@null</item> | ||
| <item name="rippleColor">@android:color/transparent</item> | ||
| </style> |
There was a problem hiding this comment.
따로 만들지 않고 이미 만들어둔 Theme.Pingle.Chip 을 사용하는 게 좋을 것 같네요 !
app/src/main/res/values/themes.xml
Outdated
| <item name="rippleColor">@android:color/transparent</item> | ||
| </style> | ||
|
|
||
| <style name="Theme.Pingle.Tag.L" parent="Theme.Pingle.Tag"> |
There was a problem hiding this comment.
Suggested change
| <style name="Theme.Pingle.Tag.L" parent="Theme.Pingle.Tag"> | |
| <style name="Theme.Pingle.Chip.Tag.L" parent="Theme.Pingle.Chip"> |
이런 식으로 해주면 되겠죠?
app/src/main/res/values/themes.xml
Outdated
Comment on lines
133
to
153
| <style name="Theme.Pingle.Tag.M" parent="Theme.Pingle.Tag"> | ||
| <item name="cornerRadius">50dp</item> | ||
| <item name="textStartPadding">10dp</item> | ||
| <item name="textEndPadding">10dp</item> | ||
| <item name="android:paddingVertical">4dp</item> | ||
| <item name="android:clickable">false</item> | ||
| <item name="chipBackgroundColor">@color/g_10</item> | ||
| <item name="android:textColor">@color/pingle_green</item> | ||
| <item name="android:textAppearance">@style/TextAppearance.Pingle.Cap.Semi.12</item> | ||
| </style> | ||
|
|
||
| <style name="Theme.Pingle.Tag.S" parent="Theme.Pingle.Tag"> | ||
| <item name="cornerRadius">50dp</item> | ||
| <item name="textStartPadding">8dp</item> | ||
| <item name="textEndPadding">8dp</item> | ||
| <item name="android:paddingVertical">3dp</item> | ||
| <item name="android:clickable">false</item> | ||
| <item name="chipBackgroundColor">@color/g_10</item> | ||
| <item name="android:textColor">@color/pingle_green</item> | ||
| <item name="android:textAppearance">@style/TextAppearance.Pingle.Cap.Semi.10</item> | ||
| </style> |
There was a problem hiding this comment.
겹치는 게 많으니 parent theme을 하나 만드는 방법도 괜찮아 보이네요 ~
There was a problem hiding this comment.
Theme.Pingle.Chip.Tag.All으로 만들어서 corenerRadius랑 backgroundTint 적용해씀다!
app/src/main/res/values/themes.xml
Outdated
| <item name="android:clickable">true</item> | ||
| <item name="chipBackgroundColor">@color/selector_pingle_tag_l_background</item> | ||
| <item name="android:textColor">@color/selector_pingle_tag_l_text_color</item> | ||
| <item name="android:textAppearance">@style/TextAppearance.Pingle.Sub.Semi.16</item> |
There was a problem hiding this comment.
체크 되고 안 되었을 때 textAppearance가 다른 것 같아요 확인 부탁합니당
jihyunniiii
reviewed
Feb 24, 2024
| @@ -95,6 +95,41 @@ | |||
| </item> | |||
| </style> | |||
|
|
|||
| <!-- tag --> | |||
| <style name="Theme.Pingle.Chip.Tag.All" parent="Theme.Pingle.Chip"> | |||
| <item name="cornerRadius">50dp</item> | |||
DoReMinWoo
approved these changes
Feb 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue 🛠
Work Description ✏️
Screenshot 📸
Uncompleted Tasks 😅
N/A
To Reviewers 📢
backgroundTint로 하면 적용이 안 되고chipBackgroundColor로 설정해야 색상이 먹네용.. 새로운 사실 겟또!