Skip to content
This repository has been archived by the owner on Dec 23, 2022. It is now read-only.

Please add React 17 support #361

Open
bodqhrohro opened this issue Nov 14, 2021 · 7 comments
Open

Please add React 17 support #361

bodqhrohro opened this issue Nov 14, 2021 · 7 comments

Comments

@bodqhrohro
Copy link

I run into a dependency conflict currently:

npm ERR! Found: [email protected]
npm ERR! node_modules/react
npm ERR!   react@"^17.0.2" from the root project
npm ERR!   peer react@"^16.8.0 || ^17.0.0" from @material-ui/[email protected]
npm ERR!   node_modules/@material-ui/core
npm ERR!     @material-ui/core@"^4.11.2" from the root project
npm ERR!     peer @material-ui/core@"^4.0.0" from [email protected]
npm ERR!     node_modules/material-ui-chip-input
npm ERR!       material-ui-chip-input@"^2.0.0-beta.2" from the root project
npm ERR!   1 more (react-dom)
npm ERR! 
npm ERR! Could not resolve dependency:
npm ERR! peer react@"^16.8.6" from [email protected]
npm ERR! node_modules/material-ui-chip-input
npm ERR!   material-ui-chip-input@"^2.0.0-beta.2" from the root project
@rn2web
Copy link

rn2web commented Jan 8, 2022

yes...we need it.

@ducqhl
Copy link

ducqhl commented Jan 27, 2022

Any update on this?

@adityarai
Copy link

Hi all, facing same issue.. any updates??

@manishprivet
Copy link

Hi all, I think the repository is dead considering the time of the last commit. I found this great codepen which utilized mui for a similar chip input.

https://codesandbox.io/s/long-morning-oubt4?file=/src/App.tsx

@Danesz
Copy link

Danesz commented Aug 21, 2022

I have forked the repo and made some modifications (I am not really a JS man), and I could make it work in my project like this:
npm i https://github.com/Danesz/material-ui-chip-input#feature/react17
(my branch is based on the latest v2 beta tag.)

oxc added a commit to oxc/material-ui-chip-input that referenced this issue Aug 31, 2022
@oxc
Copy link

oxc commented Aug 31, 2022

Based on @Danesz changes I created a pull request (well aware that there have not been any commits recently).

My change only expands the range of the peerDependency, there's no need to update the devDependencies.

@viclafouch
Copy link

Hello ! This package (https://viclafouch.github.io/mui-chips-input/) supports both React 17 / 18 and MUI V5

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants